From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2881 invoked by alias); 21 Aug 2014 18:29:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2870 invoked by uid 89); 21 Aug 2014 18:29:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 Aug 2014 18:29:09 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7LIT8Yr010516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 21 Aug 2014 14:29:08 -0400 Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7LIT4pi024408 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 21 Aug 2014 14:29:07 -0400 Date: Thu, 21 Aug 2014 18:29:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PUSHED] Remove useless gcore command detection (was: Re: [patch+7.8?] Fix 'gcore' with exited threads) Message-ID: <20140821182904.GA19056@host2.jankratochvil.net> References: <20140609203020.GA22447@host2.jankratochvil.net> <53A8427D.6070902@redhat.com> <20140817211647.GA17152@host2.jankratochvil.net> <53F5CCC8.3010903@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53F5CCC8.3010903@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00488.txt.bz2 On Thu, 21 Aug 2014 12:41:12 +0200, Pedro Alves wrote: > On 08/17/2014 10:16 PM, Jan Kratochvil wrote: > >> > I believe this is is stale -- gcore.o has been in COMMON_OBS for a while > >> > now. I think the actual error will be whatever the default for the target > >> > method throws. > > Likewise two paragraphs above. Not sure what I should do with it: > > * If I remove the test from this my testcase and someone later fixes > > the 6 existing instances of this test this only test will remain unfixed. > > * If I waste the time reading the sources what should be the expected output > > I risk the test will not work anyway as I read it wrongly. > > And I will probably wrongly modify 6 other testsuite cases. > > * I can try to find a platform without gcore but in most cases in the past my > > attempts to build GDB on any non-Linux platforms failed. > > No no, you misunderstand, we should just delete it completely. > It's a useless test. See patch below. I understood it perfectly. I just did not want to invest time into writing the off-topic patch and writing its ChangeLog for the patch you wrote below. It is now solved and I can remove the gcore test also from my patch, thanks. Jan