From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: --with-babeltrace generates many FAILs
Date: Tue, 19 Aug 2014 14:08:00 -0000 [thread overview]
Message-ID: <20140819140755.GA30208@host2.jankratochvil.net> (raw)
In-Reply-To: <53F3457E.5030205@codesourcery.com>
On Tue, 19 Aug 2014 14:39:26 +0200, Yao Qi wrote:
> I can reproduce it on my Fedora 20 x86 machine. Let me know it
> works for you or not.
Yes, it works for me (Fedora 21pre x86_64).
Just suggesting:
* '#if HAVE_LIBBABELTRACE1_1_0' could have a comment that >=1.1.1 rejects the
faked packet (what you described in the mail but not in the patch).
* It is always better to check for feature/defect than to check for version.
For example because various distros backport various fixes (unfortunately
including their possible regressions/defects) and so version checks may be
misleading then. At least in this case it seems to me as possible to check
how libbacktrace behaves from configure; although maybe it is not easy
enough, not sure.
Thanks,
Jan
next prev parent reply other threads:[~2014-08-19 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140816204614.GA7000@host2.jankratochvil.net>
2014-08-19 12:43 ` Yao Qi
2014-08-19 14:08 ` Jan Kratochvil [this message]
2014-08-20 4:06 ` Yao Qi
2014-08-20 9:41 ` Pedro Alves
2014-08-20 11:38 ` Yao Qi
2014-08-20 13:56 ` Pedro Alves
2014-08-21 4:57 ` Yao Qi
2014-08-21 12:48 ` Pedro Alves
2014-08-22 3:52 ` Yao Qi
2014-08-26 20:27 ` [for 7.8?] " Jan Kratochvil
2014-08-27 8:27 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819140755.GA30208@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox