From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32181 invoked by alias); 19 Aug 2014 14:08:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32159 invoked by uid 89); 19 Aug 2014 14:08:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 19 Aug 2014 14:08:03 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7JE7xT9030539 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Aug 2014 10:07:59 -0400 Received: from host2.jankratochvil.net (ovpn-116-72.ams2.redhat.com [10.36.116.72]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7JE7tMG025880 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Tue, 19 Aug 2014 10:07:58 -0400 Date: Tue, 19 Aug 2014 14:08:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: "gdb-patches@sourceware.org" Subject: Re: --with-babeltrace generates many FAILs Message-ID: <20140819140755.GA30208@host2.jankratochvil.net> References: <20140816204614.GA7000@host2.jankratochvil.net> <53F3457E.5030205@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53F3457E.5030205@codesourcery.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00350.txt.bz2 On Tue, 19 Aug 2014 14:39:26 +0200, Yao Qi wrote: > I can reproduce it on my Fedora 20 x86 machine. Let me know it > works for you or not. Yes, it works for me (Fedora 21pre x86_64). Just suggesting: * '#if HAVE_LIBBABELTRACE1_1_0' could have a comment that >=1.1.1 rejects the faked packet (what you described in the mail but not in the patch). * It is always better to check for feature/defect than to check for version. For example because various distros backport various fixes (unfortunately including their possible regressions/defects) and so version checks may be misleading then. At least in this case it seems to me as possible to check how libbacktrace behaves from configure; although maybe it is not easy enough, not sure. Thanks, Jan