[PATCH] Regenerate gdb/configure (Re: Skip ld/lto tests if plugins is disabled for binutils?)

[PATCH] Regenerate gdb/configure (Re: Skip ld/lto tests if plugins is disabled for binutils?)

[Yao Qi]

On 08/12/2014 09:14 PM, Alan Modra wrote:
>     configury changes to make ld plugin support controlled by --enable-plugins
>     
>     This also makes --enable-plugins default to on for hosts that can
>     support plugins, so we have consistent lto toolchain support.  The
>     ACX_LARGEFILE moves aren't strictly necessary, but are harmless and
>     will be necessary if plugin support is extended to more hosts via
>     libtool's dlopen support.  I started down that path then decided it
>     was more work than I was interested in doing.  (ACX_LARGEFILE invokes
>     AC_PLUGINS.)

The config/plugins.m4 was updated recently by commit
b879806f2fdd2eca7092d7b854d6cbbbbbd0493b.  Various sourceware components
configure files were updated except GDB's.  I run aclocal and autoconf
to update gdb/configure.

I'll push it in in one day or two, if no comments.

-- 
Yao (齐尧)

gdb:

2014-08-19  Yao Qi  <yao@codesourcery.com>

	* configure: Regenerate.
---
 gdb/configure | 45 ++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 38 insertions(+), 7 deletions(-)

diff --git a/gdb/configure b/gdb/configure
index 874922d..0b992ed 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -1482,7 +1482,7 @@ Optional Features:
   --enable-FEATURE[=ARG]  include FEATURE [ARG=yes]
   --enable-maintainer-mode  enable make rules and dependencies not useful
 			  (and sometimes confusing) to the casual installer
-  --enable-plugins        Enable support for plugins (defaults no)
+  --enable-plugins        Enable support for plugins
   --disable-largefile     omit support for large files
   --enable-targets=TARGETS
                           alternative target configurations
@@ -4090,15 +4090,46 @@ test -n "$target_alias" &&
 # even in directories otherwise not depending on the $plugins option.
 
 
-# Check whether --enable-plugins was given.
+  maybe_plugins=no
+  for ac_header in dlfcn.h
+do :
+  ac_fn_c_check_header_compile "$LINENO" "dlfcn.h" "ac_cv_header_dlfcn_h" "$ac_includes_default
+"
+if test "x$ac_cv_header_dlfcn_h" = x""yes; then :
+  cat >>confdefs.h <<_ACEOF
+#define HAVE_DLFCN_H 1
+_ACEOF
+ maybe_plugins=yes
+fi
+
+done
+
+  for ac_header in windows.h
+do :
+  ac_fn_c_check_header_compile "$LINENO" "windows.h" "ac_cv_header_windows_h" "$ac_includes_default
+"
+if test "x$ac_cv_header_windows_h" = x""yes; then :
+  cat >>confdefs.h <<_ACEOF
+#define HAVE_WINDOWS_H 1
+_ACEOF
+ maybe_plugins=yes
+fi
+
+done
+
+
+  # Check whether --enable-plugins was given.
 if test "${enable_plugins+set}" = set; then :
   enableval=$enable_plugins; case "${enableval}" in
-  yes | "") plugins=yes ;;
-  no) plugins=no ;;
-  *) plugins=yes ;;
- esac
+      no) plugins=no ;;
+      *) plugins=yes
+         if test "$maybe_plugins" != "yes" ; then
+	   as_fn_error "Building with plugin support requires a host that supports dlopen." "$LINENO" 5
+	 fi ;;
+     esac
 else
-  plugins=no
+  plugins=$maybe_plugins
+
 fi
 
 
-- 
1.9.3

Re: [PATCH] Regenerate gdb/configure (Re: Skip ld/lto tests if plugins is disabled for binutils?)

[Yao Qi]

On 08/19/2014 10:48 AM, Yao Qi wrote:
> configure files were updated except GDB's.  I run aclocal and autoconf
> to update gdb/configure.

> 2014-08-19  Yao Qi  <yao@codesourcery.com>
> 
> 	* configure: Regenerate.

Ur, I should run autoreconf instead, and get gdb/config.in updated too.
Here is the updated patch.

-- 
Yao (齐尧)

gdb:

2014-08-19  Yao Qi  <yao@codesourcery.com>

	* configure: Regenerate.
	* config.in: Regenerate.
---
 gdb/config.in |  3 +++
 gdb/configure | 45 ++++++++++++++++++++++++++++++++++++++-------
 2 files changed, 41 insertions(+), 7 deletions(-)

diff --git a/gdb/config.in b/gdb/config.in
index fb9b0cd..b853412 100644
--- a/gdb/config.in
+++ b/gdb/config.in
@@ -531,6 +531,9 @@
 /* Define to 1 if you have the `wborder' function. */
 #undef HAVE_WBORDER
 
+/* Define to 1 if you have the <windows.h> header file. */
+#undef HAVE_WINDOWS_H
+
 /* Define to 1 if `fork' works. */
 #undef HAVE_WORKING_FORK
 
diff --git a/gdb/configure b/gdb/configure
index 874922d..0b992ed 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -1482,7 +1482,7 @@ Optional Features:
   --enable-FEATURE[=ARG]  include FEATURE [ARG=yes]
   --enable-maintainer-mode  enable make rules and dependencies not useful
 			  (and sometimes confusing) to the casual installer
-  --enable-plugins        Enable support for plugins (defaults no)
+  --enable-plugins        Enable support for plugins
   --disable-largefile     omit support for large files
   --enable-targets=TARGETS
                           alternative target configurations
@@ -4090,15 +4090,46 @@ test -n "$target_alias" &&
 # even in directories otherwise not depending on the $plugins option.
 
 
-# Check whether --enable-plugins was given.
+  maybe_plugins=no
+  for ac_header in dlfcn.h
+do :
+  ac_fn_c_check_header_compile "$LINENO" "dlfcn.h" "ac_cv_header_dlfcn_h" "$ac_includes_default
+"
+if test "x$ac_cv_header_dlfcn_h" = x""yes; then :
+  cat >>confdefs.h <<_ACEOF
+#define HAVE_DLFCN_H 1
+_ACEOF
+ maybe_plugins=yes
+fi
+
+done
+
+  for ac_header in windows.h
+do :
+  ac_fn_c_check_header_compile "$LINENO" "windows.h" "ac_cv_header_windows_h" "$ac_includes_default
+"
+if test "x$ac_cv_header_windows_h" = x""yes; then :
+  cat >>confdefs.h <<_ACEOF
+#define HAVE_WINDOWS_H 1
+_ACEOF
+ maybe_plugins=yes
+fi
+
+done
+
+
+  # Check whether --enable-plugins was given.
 if test "${enable_plugins+set}" = set; then :
   enableval=$enable_plugins; case "${enableval}" in
-  yes | "") plugins=yes ;;
-  no) plugins=no ;;
-  *) plugins=yes ;;
- esac
+      no) plugins=no ;;
+      *) plugins=yes
+         if test "$maybe_plugins" != "yes" ; then
+	   as_fn_error "Building with plugin support requires a host that supports dlopen." "$LINENO" 5
+	 fi ;;
+     esac
 else
-  plugins=no
+  plugins=$maybe_plugins
+
 fi
 
 
-- 
1.9.3

Re: [PATCH] Regenerate gdb/configure (Re: Skip ld/lto tests if plugins is disabled for binutils?)

[Joel Brobecker]

> 2014-08-19  Yao Qi  <yao@codesourcery.com>
> 
> 	* configure: Regenerate.
> 	* config.in: Regenerate.

OK to push how.

Thank you!

-- 
Joel