From: Alan Modra <amodra@gmail.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: hjl.tools@gmail.com, nickc@redhat.com, binutils@sourceware.org,
gdb-patches@sourceware.org
Subject: Re: [PATCH] bfd/coff-ppc.c: Be sure of zero terminated string after copy from '_n_name'
Date: Thu, 07 Aug 2014 06:15:00 -0000 [thread overview]
Message-ID: <20140807061500.GX8921@bubble.grove.modra.org> (raw)
In-Reply-To: <53E30702.1040709@gmail.com>
On Thu, Aug 07, 2014 at 12:56:34PM +0800, Chen Gang wrote:
> On 08/07/2014 09:51 AM, Alan Modra wrote:
> > On Wed, Aug 06, 2014 at 11:52:31PM +0800, Chen Gang wrote:
> >> '_n_name' may not be zero terminated string, and it may copy to 'name'
> >> or 'my_name' which are assumed that must be zero terminated string. So
> >> during copy operation, need be sure of them zero terminated.
> >>
> >> Also remove the usless asignment to 'name'.
> >>
> >> 2014-08-06 Chen Gang <gang.chen.5i5j@gmail.com>
> >>
> >> * coff-ppc.c (coff_ppc_relocate_section): Be sure of zero
> >> terminatedstring after copy from '_n_name'.
> >
> > This is OK.
> >
>
> Excuse me, my English is not quite well, I don't quite understand your
> meaning, I guess your meaning is: "This patch is OK to you, if no any
> objections next, it can be applied by the related maintainers".
I meant, the patch is OK for you to commit, but I guess you don't have
commit rights. I've committed the patch for you. Thanks!
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2014-08-07 6:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 15:52 Chen Gang
2014-08-07 1:52 ` Alan Modra
2014-08-07 4:56 ` Chen Gang
2014-08-07 6:15 ` Alan Modra [this message]
2014-08-07 9:06 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807061500.GX8921@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gang.chen.5i5j@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox