From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12252 invoked by alias); 7 Aug 2014 06:15:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12233 invoked by uid 89); 7 Aug 2014 06:15:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pd0-f176.google.com Received: from mail-pd0-f176.google.com (HELO mail-pd0-f176.google.com) (209.85.192.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 07 Aug 2014 06:15:09 +0000 Received: by mail-pd0-f176.google.com with SMTP id y10so4607904pdj.7 for ; Wed, 06 Aug 2014 23:15:06 -0700 (PDT) X-Received: by 10.67.1.195 with SMTP id bi3mr15927040pad.74.1407392106461; Wed, 06 Aug 2014 23:15:06 -0700 (PDT) Received: from bubble.grove.modra.org (CPE-58-160-155-134.oycza5.sa.bigpond.net.au. [58.160.155.134]) by mx.google.com with ESMTPSA id ec10sm11029503pad.33.2014.08.06.23.15.04 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 06 Aug 2014 23:15:05 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 8A226EA33E5; Thu, 7 Aug 2014 15:45:00 +0930 (CST) Date: Thu, 07 Aug 2014 06:15:00 -0000 From: Alan Modra To: Chen Gang Cc: hjl.tools@gmail.com, nickc@redhat.com, binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] bfd/coff-ppc.c: Be sure of zero terminated string after copy from '_n_name' Message-ID: <20140807061500.GX8921@bubble.grove.modra.org> Mail-Followup-To: Chen Gang , hjl.tools@gmail.com, nickc@redhat.com, binutils@sourceware.org, gdb-patches@sourceware.org References: <53E24F3F.2050701@gmail.com> <20140807015153.GV8921@bubble.grove.modra.org> <53E30702.1040709@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53E30702.1040709@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-08/txt/msg00128.txt.bz2 On Thu, Aug 07, 2014 at 12:56:34PM +0800, Chen Gang wrote: > On 08/07/2014 09:51 AM, Alan Modra wrote: > > On Wed, Aug 06, 2014 at 11:52:31PM +0800, Chen Gang wrote: > >> '_n_name' may not be zero terminated string, and it may copy to 'name' > >> or 'my_name' which are assumed that must be zero terminated string. So > >> during copy operation, need be sure of them zero terminated. > >> > >> Also remove the usless asignment to 'name'. > >> > >> 2014-08-06 Chen Gang > >> > >> * coff-ppc.c (coff_ppc_relocate_section): Be sure of zero > >> terminatedstring after copy from '_n_name'. > > > > This is OK. > > > > Excuse me, my English is not quite well, I don't quite understand your > meaning, I guess your meaning is: "This patch is OK to you, if no any > objections next, it can be applied by the related maintainers". I meant, the patch is OK for you to commit, but I guess you don't have commit rights. I've committed the patch for you. Thanks! -- Alan Modra Australia Development Lab, IBM