From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: gbenson@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4 v2] Refactor shared code in i386-{nat,low}.[ch]
Date: Wed, 18 Jun 2014 16:06:00 -0000 [thread overview]
Message-ID: <201406181606.s5IG6Mud000672@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <1403104976-2492-1-git-send-email-gbenson@redhat.com> (message from Gary Benson on Wed, 18 Jun 2014 16:22:52 +0100)
> From: Gary Benson <gbenson@redhat.com>
> Date: Wed, 18 Jun 2014 16:22:52 +0100
>
> Hi all,
>
> This series continues on from the refactoring series I posted
> yesterday and partially committed today:
>
> 1 - Partially revert 4be83cc2b28ea09aa8ff789839e6520df60836f8
>
> Pedro spotted that i386_{insert,remove}_hw_breakpoint could be
> further refactored. Patch 2 of this series does precisely that.
> This change means a number of functions I made nonstatic do not
> now have to be. This patch reverts that change. I apologise
> for this noise but the end result is better.
>
> 2 - Refactor i386_{insert,remove}_hw_breakpoint
>
> As above.
>
> 3 - Create nat/i386-dregs.c
>
> This patch moves all the code from the various files into
> the new file nat/i386-dregs.c and adds it to the buildsystem.
>
> 4 - Directly call i386-dregs functions
>
> This patch is a small tidyup of i386-nat.c.
>
> Is this ok to commit?
What is the whole point about this excercise?
next prev parent reply other threads:[~2014-06-18 16:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 15:23 Gary Benson
2014-06-18 15:23 ` [PATCH 1/4 v2] Partially revert 4be83cc2b28ea09aa8ff789839e6520df60836f8 Gary Benson
2014-06-19 9:10 ` Pedro Alves
2014-06-18 15:23 ` [PATCH 4/4 v2] Directly call i386-dregs functions Gary Benson
2014-06-19 9:11 ` Pedro Alves
2014-06-18 15:23 ` [PATCH 2/4 v2] Refactor i386_{insert,remove}_hw_breakpoint Gary Benson
2014-06-19 9:10 ` Pedro Alves
2014-06-18 15:53 ` [PATCH 3/4 v2] Create nat/i386-dregs.c Gary Benson
2014-06-19 9:11 ` Pedro Alves
2014-06-18 16:06 ` Mark Kettenis [this message]
2014-06-18 16:10 ` [PATCH 0/4 v2] Refactor shared code in i386-{nat,low}.[ch] Pedro Alves
2014-06-18 17:48 ` Mark Kettenis
2014-06-18 18:01 ` Pedro Alves
2014-06-19 10:45 ` Pedro Alves
2014-06-19 10:07 ` [COMMITTED PATCH " Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201406181606.s5IG6Mud000672@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox