From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20789 invoked by alias); 18 Jun 2014 16:06:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20780 invoked by uid 89); 18 Jun 2014 16:06:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: glazunov.sibelius.xs4all.nl Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Jun 2014 16:06:36 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id s5IG6NAo015232; Wed, 18 Jun 2014 18:06:23 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id s5IG6Mud000672; Wed, 18 Jun 2014 18:06:22 +0200 (CEST) Date: Wed, 18 Jun 2014 16:06:00 -0000 Message-Id: <201406181606.s5IG6Mud000672@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: gbenson@redhat.com CC: gdb-patches@sourceware.org In-reply-to: <1403104976-2492-1-git-send-email-gbenson@redhat.com> (message from Gary Benson on Wed, 18 Jun 2014 16:22:52 +0100) Subject: Re: [PATCH 0/4 v2] Refactor shared code in i386-{nat,low}.[ch] References: <1403104976-2492-1-git-send-email-gbenson@redhat.com> X-SW-Source: 2014-06/txt/msg00678.txt.bz2 > From: Gary Benson > Date: Wed, 18 Jun 2014 16:22:52 +0100 > > Hi all, > > This series continues on from the refactoring series I posted > yesterday and partially committed today: > > 1 - Partially revert 4be83cc2b28ea09aa8ff789839e6520df60836f8 > > Pedro spotted that i386_{insert,remove}_hw_breakpoint could be > further refactored. Patch 2 of this series does precisely that. > This change means a number of functions I made nonstatic do not > now have to be. This patch reverts that change. I apologise > for this noise but the end result is better. > > 2 - Refactor i386_{insert,remove}_hw_breakpoint > > As above. > > 3 - Create nat/i386-dregs.c > > This patch moves all the code from the various files into > the new file nat/i386-dregs.c and adds it to the buildsystem. > > 4 - Directly call i386-dregs functions > > This patch is a small tidyup of i386-nat.c. > > Is this ok to commit? What is the whole point about this excercise?