Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org, Yao Qi <yao@codesourcery.com>
Subject: Re: [PATCH v2] Fix several "set remote foo-packet on/off" commands.
Date: Tue, 29 Apr 2014 12:53:00 -0000	[thread overview]
Message-ID: <20140429125351.GB4420@adacore.com> (raw)
In-Reply-To: <535EF9DC.4050706@redhat.com>

Hi Pedro,

> Bummer, sorry for the trouble.

No problem at all!

> I think the design is sound.  See more info in the patch below.
> 
> I'd be fine with either:
> 
> - restoring things to how they've "always" been immediately.
> That is, push the patch below.  We can then incrementally add the
> missing associated commands, along with corresponding manual and
> possibly testsuite changes/additions, as a non-priority task.
> 
> - or, adding all the missing commands now, and add an assertion just
> like in the patch below, but with no exception list, of course.
> (but TBC, I can't offer to work on that myself now.)

Either approach would be fine with me too. I could even see a two-step
approach where we apply your first patch as a stop-gap, and then
implement everything as a setting (I think having the setting for
every packet could prove useful to interact with difficult remote
stubs).

Thanks!
-- 
Joel


  parent reply	other threads:[~2014-04-29 12:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31 23:53 [PATCH] " Pedro Alves
2014-04-01  8:55 ` Yao Qi
2014-04-01 12:07   ` Pedro Alves
2014-04-01 12:25     ` [PATCH v2] " Pedro Alves
2014-04-28 19:16       ` Joel Brobecker
2014-04-29  1:01         ` Pedro Alves
2014-04-29  2:10           ` Hui Zhu
2014-04-29 12:53           ` Joel Brobecker [this message]
2014-04-29 13:07             ` Pedro Alves
2014-04-29 14:05               ` Joel Brobecker
2014-04-01 12:48     ` [PATCH] " Yao Qi
2014-04-25 18:04       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140429125351.GB4420@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox