From: Joel Brobecker <brobecker@adacore.com>
To: Marcus Shawcroft <marcus.shawcroft@arm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Drop prefix from unsupported source path.
Date: Wed, 16 Apr 2014 15:34:00 -0000 [thread overview]
Message-ID: <20140416153428.GA5002@adacore.com> (raw)
In-Reply-To: <533972A1.6030604@arm.com>
> Various gdb tests report the absolute path to a source file in an
> UNSUPPORTED outcome. This creates noise when comparing result
> output with previous test runs. This patch drops the directory
> prefix from the reported path in a couple of the offending
> unsupported calls.
[...]
> 2014-03-31 Marcus Shawcroft <marcus.shawcroft@arm.com>
>
> * lib/gdb.exp (gdb_compile_pthreads, gdb_compile_objc):
> Drop prefix from unsupported source file path.
Sorry for the delay. This is OK.
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 73e935a..dd59738 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -2828,7 +2828,7 @@ proc gdb_compile_pthreads {source dest type options} {
> }
> }
> if {!$built_binfile} {
> - unsupported "Couldn't compile $source: ${why_msg}"
> + unsupported "Couldn't compile [file tail $source]: ${why_msg}"
> return -1
> }
> }
> @@ -3000,7 +3000,7 @@ proc gdb_compile_objc {source dest type options} {
> }
> }
> if {!$built_binfile} {
> - unsupported "Couldn't compile $source: ${why_msg}"
> + unsupported "Couldn't compile [file tail $source]: ${why_msg}"
> return -1
> }
> }
Thanks,
--
Joel
prev parent reply other threads:[~2014-04-16 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 13:50 Marcus Shawcroft
2014-04-16 9:56 ` Marcus Shawcroft
2014-04-16 15:34 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416153428.GA5002@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=marcus.shawcroft@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox