From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28186 invoked by alias); 16 Apr 2014 15:34:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28124 invoked by uid 89); 16 Apr 2014 15:34:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 16 Apr 2014 15:34:24 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7841611612E; Wed, 16 Apr 2014 11:34:22 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id g++dPxbTOUJQ; Wed, 16 Apr 2014 11:34:22 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4DB2B116126; Wed, 16 Apr 2014 11:34:22 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E313FE041B; Wed, 16 Apr 2014 08:34:28 -0700 (PDT) Date: Wed, 16 Apr 2014 15:34:00 -0000 From: Joel Brobecker To: Marcus Shawcroft Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Drop prefix from unsupported source path. Message-ID: <20140416153428.GA5002@adacore.com> References: <533972A1.6030604@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <533972A1.6030604@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-04/txt/msg00315.txt.bz2 > Various gdb tests report the absolute path to a source file in an > UNSUPPORTED outcome. This creates noise when comparing result > output with previous test runs. This patch drops the directory > prefix from the reported path in a couple of the offending > unsupported calls. [...] > 2014-03-31 Marcus Shawcroft > > * lib/gdb.exp (gdb_compile_pthreads, gdb_compile_objc): > Drop prefix from unsupported source file path. Sorry for the delay. This is OK. > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 73e935a..dd59738 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -2828,7 +2828,7 @@ proc gdb_compile_pthreads {source dest type options} { > } > } > if {!$built_binfile} { > - unsupported "Couldn't compile $source: ${why_msg}" > + unsupported "Couldn't compile [file tail $source]: ${why_msg}" > return -1 > } > } > @@ -3000,7 +3000,7 @@ proc gdb_compile_objc {source dest type options} { > } > } > if {!$built_binfile} { > - unsupported "Couldn't compile $source: ${why_msg}" > + unsupported "Couldn't compile [file tail $source]: ${why_msg}" > return -1 > } > } Thanks, -- Joel