From: Kyle McMartin <kmcmarti@redhat.com>
To: Richard Earnshaw <rearnsha@arm.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] aarch64: detect atomic sequences like other ll/sc architectures
Date: Thu, 27 Mar 2014 01:52:00 -0000 [thread overview]
Message-ID: <20140327015214.GF3075@redacted.bos.redhat.com> (raw)
In-Reply-To: <533072CF.3050702@arm.com>
On Mon, Mar 24, 2014 at 06:00:47PM +0000, Richard Earnshaw wrote:
> On 24/03/14 16:57, Joel Brobecker wrote:
> > Hello Kyle,
> >> + /* look for a conditional branch to set a breakpoint on the destination. */
> >
> > This line looks too long?
>
> Also, comments are full sentences, so begin with a capital letter and
> end with a full stop and two spaces.
>
> >> + /* and the matching store-exclusive to close it. */
> >> + if (decode_masked_match(insn, 0x3fc00000, 0x08000000))
> >
> > Same here...
>
> If you really need a continuation comment like this, then end the
> previous one with "..." and start the current one with "... and".
> Otherwise, this should be re-written as a stand-alone sentence.
>
Thanks very much, I've just posted a v2 which I hope addresses your
issues with my patch (and adds a testcase.)
regards, Kyle
prev parent reply other threads:[~2014-03-27 1:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 16:11 Kyle McMartin
2014-03-24 16:25 ` Pedro Alves
2014-03-24 16:28 ` Kyle McMartin
2014-03-24 16:57 ` Joel Brobecker
2014-03-24 18:00 ` Richard Earnshaw
2014-03-27 1:52 ` Kyle McMartin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140327015214.GF3075@redacted.bos.redhat.com \
--to=kmcmarti@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox