From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1574 invoked by alias); 27 Mar 2014 01:52:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1443 invoked by uid 89); 27 Mar 2014 01:52:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Mar 2014 01:52:23 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2R1qH5M023800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 26 Mar 2014 21:52:17 -0400 Received: from redacted.bos.redhat.com ([10.18.17.143]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2R1qEgD005941 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 26 Mar 2014 21:52:16 -0400 Date: Thu, 27 Mar 2014 01:52:00 -0000 From: Kyle McMartin To: Richard Earnshaw Cc: Joel Brobecker , "gdb-patches@sourceware.org" Subject: Re: [PATCH] aarch64: detect atomic sequences like other ll/sc architectures Message-ID: <20140327015214.GF3075@redacted.bos.redhat.com> References: <20140324161056.GB23291@redacted.bos.redhat.com> <20140324165733.GN4282@adacore.com> <533072CF.3050702@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <533072CF.3050702@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00625.txt.bz2 On Mon, Mar 24, 2014 at 06:00:47PM +0000, Richard Earnshaw wrote: > On 24/03/14 16:57, Joel Brobecker wrote: > > Hello Kyle, > >> + /* look for a conditional branch to set a breakpoint on the destination. */ > > > > This line looks too long? > > Also, comments are full sentences, so begin with a capital letter and > end with a full stop and two spaces. > > >> + /* and the matching store-exclusive to close it. */ > >> + if (decode_masked_match(insn, 0x3fc00000, 0x08000000)) > > > > Same here... > > If you really need a continuation comment like this, then end the > previous one with "..." and start the current one with "... and". > Otherwise, this should be re-written as a stand-alone sentence. > Thanks very much, I've just posted a v2 which I hope addresses your issues with my patch (and adds a testcase.) regards, Kyle