From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: sanimir.agovic@intel.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] cleanup: remove declared variables without any references
Date: Wed, 12 Feb 2014 10:58:00 -0000 [thread overview]
Message-ID: <201402121058.s1CAwaqs012192@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20140212033234.GQ5485@adacore.com> (message from Joel Brobecker on Wed, 12 Feb 2014 07:32:34 +0400)
> Date: Wed, 12 Feb 2014 07:32:34 +0400
> From: Joel Brobecker <brobecker@adacore.com>
>
> > The mipsnbsd-tdep.c one is not ok. For one thing, you're leaving
> > behind the comment describing the code. But I think this is better
> > left alone, as somebody might want to add (or put back) the missing
> > glue that uses those bits.
>
> Hey Mark! The problem with leaving them behind is that they cause
> a build failure when building the HEAD, I think, because we build
> with -Werror. Can we find a way to avoid that? For instance, could
> we #if zero the code?
Probably best to do something like that. Ideally a NetBSd devloper
would step in and fix things...
prev parent reply other threads:[~2014-02-12 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 13:55 Sanimir Agovic
2014-02-11 14:12 ` Mark Kettenis
2014-02-11 15:17 ` Agovic, Sanimir
2014-02-12 3:32 ` Joel Brobecker
2014-02-12 10:58 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402121058.s1CAwaqs012192@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=sanimir.agovic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox