From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-110296-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15029 invoked by alias); 12 Feb 2014 10:58:49 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 15013 invoked by uid 89); 12 Feb 2014 10:58:48 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: glazunov.sibelius.xs4all.nl
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 12 Feb 2014 10:58:48 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id s1CAwbEa006645;	Wed, 12 Feb 2014 11:58:37 +0100 (CET)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id s1CAwaqs012192;	Wed, 12 Feb 2014 11:58:36 +0100 (CET)
Date: Wed, 12 Feb 2014 10:58:00 -0000
Message-Id: <201402121058.s1CAwaqs012192@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
CC: sanimir.agovic@intel.com, gdb-patches@sourceware.org
In-reply-to: <20140212033234.GQ5485@adacore.com> (message from Joel Brobecker	on Wed, 12 Feb 2014 07:32:34 +0400)
Subject: Re: [PATCH] cleanup: remove declared variables without any references
References: <1392126951-25347-1-git-send-email-sanimir.agovic@intel.com> <201402111412.s1BECWEX000161@glazunov.sibelius.xs4all.nl> <20140212033234.GQ5485@adacore.com>
X-SW-Source: 2014-02/txt/msg00395.txt.bz2

> Date: Wed, 12 Feb 2014 07:32:34 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> 
> > The mipsnbsd-tdep.c one is not ok.  For one thing, you're leaving
> > behind the comment describing the code.  But I think this is better
> > left alone, as somebody might want to add (or put back) the missing
> > glue that uses those bits.
> 
> Hey Mark! The problem with leaving them behind is that they cause
> a build failure when building the HEAD, I think, because we build
> with -Werror. Can we find a way to avoid that? For instance, could
> we #if zero the code?

Probably best to do something like that.  Ideally a NetBSd devloper
would step in and fix things...