From: Joel Brobecker <brobecker@adacore.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] rl78: vtables are code addresses
Date: Tue, 11 Feb 2014 09:30:00 -0000 [thread overview]
Message-ID: <20140211093000.GM5485@adacore.com> (raw)
In-Reply-To: <20140210234449.27faedc6@redhat.com>
> I would like to commit this patch because, on balance, it markedly
> improves the test results. Without objection(s), I'll commit this
> patch in a few days time.
FWIW, I agree. Let's not allow best to be the enemy of good...
> + if (TYPE_CODE (type) == TYPE_CODE_PTR)
> + {
> + struct type *targ_type = TYPE_TARGET_TYPE (type);
> +
^^^^^^^
"trailing" spaces there...
--
Joel
next prev parent reply other threads:[~2014-02-11 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 6:44 Kevin Buettner
2014-02-11 9:30 ` Joel Brobecker [this message]
2014-02-11 10:42 ` Pedro Alves
2014-02-11 16:38 ` Kevin Buettner
2014-02-12 13:32 ` Pedro Alves
2014-02-12 19:42 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211093000.GM5485@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox