From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14118 invoked by alias); 11 Feb 2014 09:30:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14098 invoked by uid 89); 11 Feb 2014 09:30:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 11 Feb 2014 09:30:02 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C00CD11645A; Tue, 11 Feb 2014 04:30:00 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 91lbdUbJNKqj; Tue, 11 Feb 2014 04:30:00 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 641B1116297; Tue, 11 Feb 2014 04:30:00 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D42CEE05F6; Tue, 11 Feb 2014 13:30:00 +0400 (RET) Date: Tue, 11 Feb 2014 09:30:00 -0000 From: Joel Brobecker To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [RFC] rl78: vtables are code addresses Message-ID: <20140211093000.GM5485@adacore.com> References: <20140210234449.27faedc6@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140210234449.27faedc6@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00346.txt.bz2 > I would like to commit this patch because, on balance, it markedly > improves the test results. Without objection(s), I'll commit this > patch in a few days time. FWIW, I agree. Let's not allow best to be the enemy of good... > + if (TYPE_CODE (type) == TYPE_CODE_PTR) > + { > + struct type *targ_type = TYPE_TARGET_TYPE (type); > + ^^^^^^^ "trailing" spaces there... -- Joel