From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] Add ARI (ok) marker for __func__ reference in common-utils.h
Date: Wed, 22 Jan 2014 04:57:00 -0000 [thread overview]
Message-ID: <20140122045713.GZ4762@adacore.com> (raw)
In-Reply-To: <CADPb22RhU_a8tRxjo2B-=UfbVEABghuFKC5G09RxBM4sCYXSGQ@mail.gmail.com>
> > gdb/ChangeLog:
> >
> > * common/common-utils.h: Add "ARI:" comment besides __func__
> > reference.
> >
> > OK to commit?
>
> Fine by me.
Thanks!
> English nit: "... comment beside __func__ reference".
>
> I wonder though how ARI handled gdb_assert.h (where FUNCTION_NAME
> originates from).
It probably did not - it just became visible again because of
the move (as I understand it, we diff the report with the report
from the previous day, and if we find any additions, we send
them via email, and "diff" is not sophisticated enough to detect
moves).
--
Joel
next prev parent reply other threads:[~2014-01-22 4:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-18 1:52 New ARI warning Sat Jan 18 01:52:44 UTC 2014 GDB Administrator
2014-01-21 10:36 ` [PATCH 1/2] Expand documentation of common-utils.h::FUNCTION_NAME Joel Brobecker
2014-01-21 10:36 ` [PATCH 2/2] Add ARI (ok) marker for __func__ reference in common-utils.h Joel Brobecker
2014-01-22 4:44 ` Doug Evans
2014-01-22 4:57 ` Joel Brobecker [this message]
2014-01-22 5:12 ` pushed: " Joel Brobecker
2014-01-22 4:41 ` [PATCH 1/2] Expand documentation of common-utils.h::FUNCTION_NAME Doug Evans
2014-01-22 4:59 ` Joel Brobecker
2014-01-22 5:20 ` Doug Evans
2014-01-22 5:12 ` pushed: " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140122045713.GZ4762@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox