From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27867 invoked by alias); 22 Jan 2014 04:57:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27858 invoked by uid 89); 22 Jan 2014 04:57:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 22 Jan 2014 04:57:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 394CD11655C; Tue, 21 Jan 2014 23:57:13 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id MCAg82mS51Ym; Tue, 21 Jan 2014 23:57:13 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CBCF2116424; Tue, 21 Jan 2014 23:57:12 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id F0D1FE059C; Wed, 22 Jan 2014 08:57:13 +0400 (RET) Date: Wed, 22 Jan 2014 04:57:00 -0000 From: Joel Brobecker To: Doug Evans Cc: gdb-patches Subject: Re: [PATCH 2/2] Add ARI (ok) marker for __func__ reference in common-utils.h Message-ID: <20140122045713.GZ4762@adacore.com> References: <20140118015244.GA22787@sourceware.org> <1390300575-6998-1-git-send-email-brobecker@adacore.com> <1390300575-6998-2-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-01/txt/msg00838.txt.bz2 > > gdb/ChangeLog: > > > > * common/common-utils.h: Add "ARI:" comment besides __func__ > > reference. > > > > OK to commit? > > Fine by me. Thanks! > English nit: "... comment beside __func__ reference". > > I wonder though how ARI handled gdb_assert.h (where FUNCTION_NAME > originates from). It probably did not - it just became visible again because of the move (as I understand it, we diff the report with the report from the previous day, and if we find any additions, we send them via email, and "diff" is not sophisticated enough to detect moves). -- Joel