From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/python+doco/NEWS] Add gdb.Type.name attribute.
Date: Fri, 10 Jan 2014 04:02:00 -0000 [thread overview]
Message-ID: <20140110040153.GB4762@adacore.com> (raw)
In-Reply-To: <87lhyp7zos.fsf@fleche.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
> Hi Joel. Today I happened to notice:
>
> Joel> +gdb_test_no_output "source ${remote_python_file}"
>
> ... this puts the full path to the .py file into the test name.
>
> I think the test should specify a name that doesn't include a path,
> instead.
>
> This same problem affects another new test,
> gdb.ada/pp-rec-component.exp.
Indeed, thanks for pointing it out. I fixed both instances with
the attached patches.
gdb/testsuite:
2014-01-10 Joel Brobecker <brobecker@adacore.com>
* gdb.ada/pp-rec-component.exp: Remove path from "source" test.
2014-01-10 Joel Brobecker <brobecker@adacore.com>
* gdb.python/py-pp-integral.exp: Remove path from "source" test.
Tested on x86_64-linux, after verifying that the gdb.sum no longer
shows the path for the "source" tests.
Pushed.
--
Joel
[-- Attachment #2: 0001-Remove-path-from-gdb.python-py-pp-integral.exp-sourc.patch --]
[-- Type: text/x-diff, Size: 1474 bytes --]
From 4e23fced8108c99ddc9d52fb2c02af8cac4cc7bb Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Fri, 10 Jan 2014 07:50:29 +0400
Subject: [PATCH 1/2] Remove path from gdb.python/py-pp-integral.exp "source"
test.
gdb/testsuite/ChangeLog:
* gdb.python/py-pp-integral.exp: Remove path from "source" test.
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.python/py-pp-integral.exp | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 4c4dcec..283f1f2 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2014-01-10 Joel Brobecker <brobecker@adacore.com>
+
+ * gdb.python/py-pp-integral.exp: Remove path from "source" test.
+
2014-01-09 Maciej W. Rozycki <macro@codesourcery.com>
Pedro Alves <palves@redhat.com>
diff --git a/gdb/testsuite/gdb.python/py-pp-integral.exp b/gdb/testsuite/gdb.python/py-pp-integral.exp
index 1262c3f..8149bde 100644
--- a/gdb/testsuite/gdb.python/py-pp-integral.exp
+++ b/gdb/testsuite/gdb.python/py-pp-integral.exp
@@ -29,7 +29,8 @@ if ![runto tick_tock] {
set remote_python_file [gdb_remote_download host \
${srcdir}/${subdir}/${testfile}.py]
-gdb_test_no_output "source ${remote_python_file}"
+gdb_test_no_output "source ${remote_python_file}" \
+ "source ${testfile}.py"
gdb_test "print *t" " = Thu Nov 14 02:22:23 2013 \\(1384395743\\)"
--
1.8.3.2
[-- Attachment #3: 0002-Remove-path-from-gdb.ada-pp-rec-component.exp-source.patch --]
[-- Type: text/x-diff, Size: 1606 bytes --]
From a2cd8cfed14491303eb8338f90e206034c5a3fe2 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Fri, 10 Jan 2014 07:54:23 +0400
Subject: [PATCH 2/2] Remove path from gdb.ada/pp-rec-component.exp "source"
test
gdb/testsuite/ChangeLog:
* gdb.ada/pp-rec-component.exp: Remove path from "source" test.
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.ada/pp-rec-component.exp | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 283f1f2..2bfeec1 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@
2014-01-10 Joel Brobecker <brobecker@adacore.com>
+ * gdb.ada/pp-rec-component.exp: Remove path from "source" test.
+
+2014-01-10 Joel Brobecker <brobecker@adacore.com>
+
* gdb.python/py-pp-integral.exp: Remove path from "source" test.
2014-01-09 Maciej W. Rozycki <macro@codesourcery.com>
diff --git a/gdb/testsuite/gdb.ada/pp-rec-component.exp b/gdb/testsuite/gdb.ada/pp-rec-component.exp
index faa7a0f..f2e4ab2 100644
--- a/gdb/testsuite/gdb.ada/pp-rec-component.exp
+++ b/gdb/testsuite/gdb.ada/pp-rec-component.exp
@@ -28,7 +28,8 @@ if { [skip_python_tests] } { continue }
set remote_python_file \
[gdb_remote_download host ${srcdir}/${subdir}/${gdb_test_file_name}.py]
-gdb_test_no_output "source ${remote_python_file}"
+gdb_test_no_output "source ${remote_python_file}" \
+ "source ${gdb_test_file_name}.py"
set bp_location [gdb_get_line_number "BREAK" ${testdir}/foo.adb]
runto "foo.adb:$bp_location"
--
1.8.3.2
prev parent reply other threads:[~2014-01-10 4:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 3:37 Joel Brobecker
2013-12-23 3:54 ` Eli Zaretskii
2014-01-06 21:44 ` Tom Tromey
2014-01-07 3:14 ` Joel Brobecker
2014-01-09 18:55 ` Tom Tromey
2014-01-10 4:02 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110040153.GB4762@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox