From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23387 invoked by alias); 10 Jan 2014 04:02:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23364 invoked by uid 89); 10 Jan 2014 04:02:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 10 Jan 2014 04:02:00 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 631BB116529; Thu, 9 Jan 2014 23:01:58 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id KJq5KOTEF9Bi; Thu, 9 Jan 2014 23:01:58 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E7EC31164DF; Thu, 9 Jan 2014 23:01:57 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id DCC22E0401; Fri, 10 Jan 2014 08:01:53 +0400 (RET) Date: Fri, 10 Jan 2014 04:02:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA/python+doco/NEWS] Add gdb.Type.name attribute. Message-ID: <20140110040153.GB4762@adacore.com> References: <1387769845-28452-1-git-send-email-brobecker@adacore.com> <87lhyp7zos.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="VbJkn9YxBvnuCH5J" Content-Disposition: inline In-Reply-To: <87lhyp7zos.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-01/txt/msg00271.txt.bz2 --VbJkn9YxBvnuCH5J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 817 > Hi Joel. Today I happened to notice: > > Joel> +gdb_test_no_output "source ${remote_python_file}" > > ... this puts the full path to the .py file into the test name. > > I think the test should specify a name that doesn't include a path, > instead. > > This same problem affects another new test, > gdb.ada/pp-rec-component.exp. Indeed, thanks for pointing it out. I fixed both instances with the attached patches. gdb/testsuite: 2014-01-10 Joel Brobecker * gdb.ada/pp-rec-component.exp: Remove path from "source" test. 2014-01-10 Joel Brobecker * gdb.python/py-pp-integral.exp: Remove path from "source" test. Tested on x86_64-linux, after verifying that the gdb.sum no longer shows the path for the "source" tests. Pushed. -- Joel --VbJkn9YxBvnuCH5J Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Remove-path-from-gdb.python-py-pp-integral.exp-sourc.patch" Content-length: 1475 >From 4e23fced8108c99ddc9d52fb2c02af8cac4cc7bb Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Fri, 10 Jan 2014 07:50:29 +0400 Subject: [PATCH 1/2] Remove path from gdb.python/py-pp-integral.exp "source" test. gdb/testsuite/ChangeLog: * gdb.python/py-pp-integral.exp: Remove path from "source" test. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.python/py-pp-integral.exp | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 4c4dcec..283f1f2 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2014-01-10 Joel Brobecker + + * gdb.python/py-pp-integral.exp: Remove path from "source" test. + 2014-01-09 Maciej W. Rozycki Pedro Alves diff --git a/gdb/testsuite/gdb.python/py-pp-integral.exp b/gdb/testsuite/gdb.python/py-pp-integral.exp index 1262c3f..8149bde 100644 --- a/gdb/testsuite/gdb.python/py-pp-integral.exp +++ b/gdb/testsuite/gdb.python/py-pp-integral.exp @@ -29,7 +29,8 @@ if ![runto tick_tock] { set remote_python_file [gdb_remote_download host \ ${srcdir}/${subdir}/${testfile}.py] -gdb_test_no_output "source ${remote_python_file}" +gdb_test_no_output "source ${remote_python_file}" \ + "source ${testfile}.py" gdb_test "print *t" " = Thu Nov 14 02:22:23 2013 \\(1384395743\\)" -- 1.8.3.2 --VbJkn9YxBvnuCH5J Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0002-Remove-path-from-gdb.ada-pp-rec-component.exp-source.patch" Content-length: 1607 >From a2cd8cfed14491303eb8338f90e206034c5a3fe2 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Fri, 10 Jan 2014 07:54:23 +0400 Subject: [PATCH 2/2] Remove path from gdb.ada/pp-rec-component.exp "source" test gdb/testsuite/ChangeLog: * gdb.ada/pp-rec-component.exp: Remove path from "source" test. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.ada/pp-rec-component.exp | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 283f1f2..2bfeec1 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2014-01-10 Joel Brobecker + * gdb.ada/pp-rec-component.exp: Remove path from "source" test. + +2014-01-10 Joel Brobecker + * gdb.python/py-pp-integral.exp: Remove path from "source" test. 2014-01-09 Maciej W. Rozycki diff --git a/gdb/testsuite/gdb.ada/pp-rec-component.exp b/gdb/testsuite/gdb.ada/pp-rec-component.exp index faa7a0f..f2e4ab2 100644 --- a/gdb/testsuite/gdb.ada/pp-rec-component.exp +++ b/gdb/testsuite/gdb.ada/pp-rec-component.exp @@ -28,7 +28,8 @@ if { [skip_python_tests] } { continue } set remote_python_file \ [gdb_remote_download host ${srcdir}/${subdir}/${gdb_test_file_name}.py] -gdb_test_no_output "source ${remote_python_file}" +gdb_test_no_output "source ${remote_python_file}" \ + "source ${gdb_test_file_name}.py" set bp_location [gdb_get_line_number "BREAK" ${testdir}/foo.adb] runto "foo.adb:$bp_location" -- 1.8.3.2 --VbJkn9YxBvnuCH5J--