Re: gdbserver, aarch64: Zero out regs in aarch64_linux_set_debug_regs

Re: gdbserver, aarch64: Zero out regs in aarch64_linux_set_debug_regs

[Joel Brobecker]

Hello Will,

We're about to create a 7.6.2 release. To help me sent release
announcements, I need an entry in the wiki page we created for
that release branch. For 7.6.2, that's:

    https://sourceware.org/gdb/wiki/GDB_7.6_Release

Can you please add an entry that follows the format used in
the entries added for the 7.6.1 release?

I tried doing that myself, but got lost a little. AFAICT, you're
applying the same patch as one that was applied on the GDB side.
I traced the problem description back to a patch first posted in
July, but: 1. Does your patch fix the same problem/symptoms?
           2. The gdb-side patch in not part of the gdb_7_6-branch;
              is that what we want?

Thanks,
-- 
Joel

Re: gdbserver, aarch64: Zero out regs in aarch64_linux_set_debug_regs

[Will Newton]

On 25 November 2013 12:51, Joel Brobecker <brobecker@adacore.com> wrote:
> Hello Will,
>
> We're about to create a 7.6.2 release. To help me sent release
> announcements, I need an entry in the wiki page we created for
> that release branch. For 7.6.2, that's:
>
>     https://sourceware.org/gdb/wiki/GDB_7.6_Release
>
> Can you please add an entry that follows the format used in
> the entries added for the 7.6.1 release?

Sure, no problem.

> I tried doing that myself, but got lost a little. AFAICT, you're
> applying the same patch as one that was applied on the GDB side.
> I traced the problem description back to a patch first posted in
> July, but: 1. Does your patch fix the same problem/symptoms?

It fixes the same issue in gdbserver that was fixed in gdb.

>            2. The gdb-side patch in not part of the gdb_7_6-branch;
>               is that what we want?

Not really! I believed that the gdb patch had been committed to the
stable branch but later discovered that it hadn't. As the stable
branch appeared to be dormant I didn't follow up on it. Ideally both
patches should be applied and if we are going to do another release
I'm happy to cherry pick it across.

-- 
Will Newton
Toolchain Working Group, Linaro

Re: gdbserver, aarch64: Zero out regs in aarch64_linux_set_debug_regs

[Joel Brobecker]

> > We're about to create a 7.6.2 release. To help me sent release
> > announcements, I need an entry in the wiki page we created for
> > that release branch. For 7.6.2, that's:
> >
> >     https://sourceware.org/gdb/wiki/GDB_7.6_Release
> >
> > Can you please add an entry that follows the format used in
> > the entries added for the 7.6.1 release?
> 
> Sure, no problem.

Thanks!

> > I tried doing that myself, but got lost a little. AFAICT, you're
> > applying the same patch as one that was applied on the GDB side.
> > I traced the problem description back to a patch first posted in
> > July, but: 1. Does your patch fix the same problem/symptoms?
> 
> It fixes the same issue in gdbserver that was fixed in gdb.
> 
> >            2. The gdb-side patch in not part of the gdb_7_6-branch;
> >               is that what we want?
> 
> Not really! I believed that the gdb patch had been committed to the
> stable branch but later discovered that it hadn't. As the stable
> branch appeared to be dormant I didn't follow up on it. Ideally both
> patches should be applied and if we are going to do another release
> I'm happy to cherry pick it across.

Let's do that, then. I think it'll make better sense for the user,
and it'll also be easier to describe the extent of the problem being
fixed.

Thanks again!
-- 
Joel

Re: gdbserver, aarch64: Zero out regs in aarch64_linux_set_debug_regs

[Will Newton]

On 25 November 2013 13:02, Joel Brobecker <brobecker@adacore.com> wrote:
>> > We're about to create a 7.6.2 release. To help me sent release
>> > announcements, I need an entry in the wiki page we created for
>> > that release branch. For 7.6.2, that's:
>> >
>> >     https://sourceware.org/gdb/wiki/GDB_7.6_Release
>> >
>> > Can you please add an entry that follows the format used in
>> > the entries added for the 7.6.1 release?
>>
>> Sure, no problem.
>
> Thanks!
>
>> > I tried doing that myself, but got lost a little. AFAICT, you're
>> > applying the same patch as one that was applied on the GDB side.
>> > I traced the problem description back to a patch first posted in
>> > July, but: 1. Does your patch fix the same problem/symptoms?
>>
>> It fixes the same issue in gdbserver that was fixed in gdb.
>>
>> >            2. The gdb-side patch in not part of the gdb_7_6-branch;
>> >               is that what we want?
>>
>> Not really! I believed that the gdb patch had been committed to the
>> stable branch but later discovered that it hadn't. As the stable
>> branch appeared to be dormant I didn't follow up on it. Ideally both
>> patches should be applied and if we are going to do another release
>> I'm happy to cherry pick it across.
>
> Let's do that, then. I think it'll make better sense for the user,
> and it'll also be easier to describe the extent of the problem being
> fixed.

Just to confirm - this patch should be applied to the gdb_7_6-branch in CVS?

-- 
Will Newton
Toolchain Working Group, Linaro

Re: gdbserver, aarch64: Zero out regs in aarch64_linux_set_debug_regs

[Joel Brobecker]

> >> >            2. The gdb-side patch in not part of the gdb_7_6-branch;
> >> >               is that what we want?
> >>
> >> Not really! I believed that the gdb patch had been committed to the
> >> stable branch but later discovered that it hadn't. As the stable
> >> branch appeared to be dormant I didn't follow up on it. Ideally both
> >> patches should be applied and if we are going to do another release
> >> I'm happy to cherry pick it across.
> >
> > Let's do that, then. I think it'll make better sense for the user,
> > and it'll also be easier to describe the extent of the problem being
> > fixed.
> 
> Just to confirm - this patch should be applied to the gdb_7_6-branch in CVS?

In the git repository, actually (CVS is closed, and I will be making
the new release using the git repo).

Thank you,
-- 
Joel

Re: gdbserver, aarch64: Zero out regs in aarch64_linux_set_debug_regs

[Will Newton]

On 25 November 2013 15:24, Joel Brobecker <brobecker@adacore.com> wrote:
>> >> >            2. The gdb-side patch in not part of the gdb_7_6-branch;
>> >> >               is that what we want?
>> >>
>> >> Not really! I believed that the gdb patch had been committed to the
>> >> stable branch but later discovered that it hadn't. As the stable
>> >> branch appeared to be dormant I didn't follow up on it. Ideally both
>> >> patches should be applied and if we are going to do another release
>> >> I'm happy to cherry pick it across.
>> >
>> > Let's do that, then. I think it'll make better sense for the user,
>> > and it'll also be easier to describe the extent of the problem being
>> > fixed.
>>
>> Just to confirm - this patch should be applied to the gdb_7_6-branch in CVS?
>
> In the git repository, actually (CVS is closed, and I will be making
> the new release using the git repo).

Ok, cherry-picked and pushed. I also updated the wiki. Unfortunately
there doesn't seem to be a PR for the issue.

-- 
Will Newton
Toolchain Working Group, Linaro

Re: gdbserver, aarch64: Zero out regs in aarch64_linux_set_debug_regs

[Joel Brobecker]

> Ok, cherry-picked and pushed. I also updated the wiki. Unfortunately
> there doesn't seem to be a PR for the issue.

In that case, we need to create one, which I just did for you.
The reason why we want a PR is that we want a short description
of the problem with a short link that also works in textual
format to the problem description. When we discussed this requirement
a while back, we settled on using bugzilla. A link to the mailing
list isn't as good, especially in a case like this where the email
thread got silent for a couple of months before resurecting. With
the PR, we can add information again anytime, and we know everything
will remain pieced together.

Long story short: You're good, now :).

Thanks!
-- 
Joel