Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: bug-readline@gnu.org
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	Martin Benda <martin.benda@omsquare.com>
Subject: Re: [PATCH] Fix compilation error in readline/util.c in environments with missing strcasecmp
Date: Sat, 21 Sep 2013 13:48:00 -0000	[thread overview]
Message-ID: <20130921134837.GV3132@adacore.com> (raw)
In-Reply-To: <04BF4C19-304E-4CEB-964B-06CEF63E3DCC@omsquare.com>

Hi Chet,

Martin just sent us this patch, which indedd looks trivial, but we
thought we'd run it by you first so you could apply it in the official
repository first if you agree. On our end, we'll apply the fix you
decide to apply.

Thank you both!

> when building GDB 7.6.1 in MinGW (Windows 7) for the arm-none-eabi
> target, I got compilation error in readline/util.c:392 --- missing
> semicolon after do { ... } while (...) loop. The attached patch fixes
> this trivial error.
> 
> 
> 2013-09-21  Martin Benda  <martin.benda@omsquare.com>
> 
> 	* readline/util.c: Add missing semicolon to fix compilation error
> 	in environments with missing strcasecmp (e.g. MinGW).
> 
> 
> diff -Naur gdb-7.6.1/readline/util.c dist-patched/gdb-7.6.1/readline/util.c
> --- gdb-7.6.1/readline/util.c	2013-09-21 09:28:03.000000000 +0200
> +++ gdb-7.6.1-patched/readline/util.c	2013-09-21 09:41:12.000000000 +0200
> @@ -389,7 +389,7 @@
>        break;
>      s2++;
>    }
> -  while (--count != 0)
> +  while (--count != 0);
> 
>  return (0);
> }
> 
> 
> Martin Benda

> diff -Naur gdb-7.6.1/readline/util.c dist-patched/gdb-7.6.1/readline/util.c
> --- gdb-7.6.1/readline/util.c	2013-09-21 09:28:03.000000000 +0200
> +++ gdb-7.6.1-patched/readline/util.c	2013-09-21 09:41:12.000000000 +0200
> @@ -389,7 +389,7 @@
>          break;
>        s2++;
>      }
> -  while (--count != 0)
> +  while (--count != 0);
>  
>    return (0);
>  }

> 2013-09-21  Martin Benda  <martin.benda@omsquare.com>
> 
> 	* readline/util.c: Add missing semicolon to fix compilation error
> 	in environments with missing strcasecmp (e.g. MinGW).


-- 
Joel


  reply	other threads:[~2013-09-21 13:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-21  9:05 Martin Benda
2013-09-21 13:48 ` Joel Brobecker [this message]
2013-09-22 16:59   ` [Bug-readline] " Chet Ramey
2013-09-23 16:06     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130921134837.GV3132@adacore.com \
    --to=brobecker@adacore.com \
    --cc=bug-readline@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=martin.benda@omsquare.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox