From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21228 invoked by alias); 21 Sep 2013 13:48:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21214 invoked by uid 89); 21 Sep 2013 13:48:40 -0000 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 21 Sep 2013 13:48:40 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 459D51165B3; Sat, 21 Sep 2013 09:48:53 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id g+9PPhRVc-5s; Sat, 21 Sep 2013 09:48:53 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 126EE116599; Sat, 21 Sep 2013 09:48:53 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 859E9E0FC2; Sat, 21 Sep 2013 06:48:37 -0700 (PDT) Date: Sat, 21 Sep 2013 13:48:00 -0000 From: Joel Brobecker To: bug-readline@gnu.org Cc: "gdb-patches@sourceware.org" , Martin Benda Subject: Re: [PATCH] Fix compilation error in readline/util.c in environments with missing strcasecmp Message-ID: <20130921134837.GV3132@adacore.com> References: <04BF4C19-304E-4CEB-964B-06CEF63E3DCC@omsquare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04BF4C19-304E-4CEB-964B-06CEF63E3DCC@omsquare.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-09/txt/msg00788.txt.bz2 Hi Chet, Martin just sent us this patch, which indedd looks trivial, but we thought we'd run it by you first so you could apply it in the official repository first if you agree. On our end, we'll apply the fix you decide to apply. Thank you both! > when building GDB 7.6.1 in MinGW (Windows 7) for the arm-none-eabi > target, I got compilation error in readline/util.c:392 --- missing > semicolon after do { ... } while (...) loop. The attached patch fixes > this trivial error. > > > 2013-09-21 Martin Benda > > * readline/util.c: Add missing semicolon to fix compilation error > in environments with missing strcasecmp (e.g. MinGW). > > > diff -Naur gdb-7.6.1/readline/util.c dist-patched/gdb-7.6.1/readline/util.c > --- gdb-7.6.1/readline/util.c 2013-09-21 09:28:03.000000000 +0200 > +++ gdb-7.6.1-patched/readline/util.c 2013-09-21 09:41:12.000000000 +0200 > @@ -389,7 +389,7 @@ > break; > s2++; > } > - while (--count != 0) > + while (--count != 0); > > return (0); > } > > > Martin Benda > diff -Naur gdb-7.6.1/readline/util.c dist-patched/gdb-7.6.1/readline/util.c > --- gdb-7.6.1/readline/util.c 2013-09-21 09:28:03.000000000 +0200 > +++ gdb-7.6.1-patched/readline/util.c 2013-09-21 09:41:12.000000000 +0200 > @@ -389,7 +389,7 @@ > break; > s2++; > } > - while (--count != 0) > + while (--count != 0); > > return (0); > } > 2013-09-21 Martin Benda > > * readline/util.c: Add missing semicolon to fix compilation error > in environments with missing strcasecmp (e.g. MinGW). -- Joel