Re: [PATCH] Skip VDSO when reading SO list

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Fri, 20 Sep 2013 15:15:49 +0200, Jan Kratochvil wrote:
> On Mon, 19 Aug 2013 16:44:13 +0200, Andreas Arnez wrote:
[...]
> > @@ -1349,10 +1350,22 @@ svr4_read_so_list (CORE_ADDR lm, CORE_AD
> >  	{
> >  	  struct svr4_info *info = get_svr4_info ();
> >  
> > +	  first = new;
> >  	  info->main_lm_addr = new->lm_info->lm_addr;
> >  	  do_cleanups (old_chain);
> >  	  continue;
> >  	}
> > +
> > +      /* The l_name of a VDSO sometimes lies in read-only memory that
>                             vDSO
> > +	 is excluded from a core dump.  In order to avoid the "can't
> > +	 read pathname" warning, we try to identify the VDSO.  One
>                                                         vDSO
> > +	 criteria is that the l_name address matches that of the main
> > +	 executable.  */
> > +      if (first && new->lm_info->l_name == first->lm_info->l_name)
> 
> Here should be also '&& ignore_first'.

I see now it is not needed.  FIRST would stay NULL in such case.

According to the GDB Coding standards s/first/first != NULL/ because FIRST is
a pointer.


Thanks,
Jan