From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19073 invoked by alias); 20 Sep 2013 15:27:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19063 invoked by uid 89); 20 Sep 2013 15:27:15 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Sep 2013 15:27:15 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8KFRCLY001984 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 20 Sep 2013 11:27:12 -0400 Received: from host2.jankratochvil.net (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r8KFR8NB025284 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 20 Sep 2013 11:27:11 -0400 Date: Fri, 20 Sep 2013 15:27:00 -0000 From: Jan Kratochvil To: Andreas Arnez Cc: gdb-patches@sourceware.org, Andreas Krebbel Subject: Re: [PATCH] Skip VDSO when reading SO list Message-ID: <20130920152708.GA854@host2.jankratochvil.net> References: <87d2p9oi4i.fsf@br87z6lw.de.ibm.com> <20130920131549.GA18629@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130920131549.GA18629@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00767.txt.bz2 On Fri, 20 Sep 2013 15:15:49 +0200, Jan Kratochvil wrote: > On Mon, 19 Aug 2013 16:44:13 +0200, Andreas Arnez wrote: [...] > > @@ -1349,10 +1350,22 @@ svr4_read_so_list (CORE_ADDR lm, CORE_AD > > { > > struct svr4_info *info = get_svr4_info (); > > > > + first = new; > > info->main_lm_addr = new->lm_info->lm_addr; > > do_cleanups (old_chain); > > continue; > > } > > + > > + /* The l_name of a VDSO sometimes lies in read-only memory that > vDSO > > + is excluded from a core dump. In order to avoid the "can't > > + read pathname" warning, we try to identify the VDSO. One > vDSO > > + criteria is that the l_name address matches that of the main > > + executable. */ > > + if (first && new->lm_info->l_name == first->lm_info->l_name) > > Here should be also '&& ignore_first'. I see now it is not needed. FIRST would stay NULL in such case. According to the GDB Coding standards s/first/first != NULL/ because FIRST is a pointer. Thanks, Jan