Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Raunaq 12 <raunaq12@in.ibm.com>,
	GDB Patches <gdb-patches@sourceware.org>,
	Mark Kettenis <mark.kettenis@xs4all.nl>,
	Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
Subject: Re: [RFA/ppc-aix] fix thread support breakage (was: "Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined.")
Date: Fri, 23 Aug 2013 13:34:00 -0000	[thread overview]
Message-ID: <20130823133415.GD5221@adacore.com> (raw)
In-Reply-To: <CAGWvnymjyCc9vFbh4+eNdr2mdxJYU0=LFC1-itC38SDKfRaG-w@mail.gmail.com>

> > gdb/ChangeLog:
> >
> >         * rs6000-nat.c (rs6000_ptrace32): Cast "addr" to "uintptr_t"
> >         instead of "long long" in call to ptrace64.
> >
> > Tested on ppc-aix in full 32bit mode (both GDB and inferior are
> > 32bit). I think the other scenario would be 64bit GDB debugging
> > a 32bit inferior, but I don't have a 64bit compiler to try it.
> >
> > I'd like to commit this patch, unless there are comments/suggestions.
> 
> LGTM.

Thanks :)

> Is there a testcase that can be added to the GDB testsuite to catch
> this type of regression?

All testcases involving thread support should reveal this type of
failure. I cannot remember exactly how this patch was tested, but
ISTR that it couldn't be tested through the official testsuite,
for some reasons that were deemed reasonable...

-- 
Joel


  reply	other threads:[~2013-08-23 13:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAGWvnynVeLt6F-QREsP_CtQvwvtZgwqHxtcS6pn58LMf=AX=GA@mail.gmail.com>
2013-08-12 12:02 ` [PATCH 4/5] powerpc64-aix ptrace64 when defined Raunaq 12
2013-08-12 15:53   ` David Edelsohn
2013-08-12 12:11 ` Raunaq 12
2013-08-12 19:43   ` David Edelsohn
2013-08-22 23:32     ` Joel Brobecker
2013-08-23  0:48       ` [RFA/ppc-aix] fix thread support breakage (was: "Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined.") Joel Brobecker
2013-08-23  7:23         ` David Edelsohn
2013-08-23 13:34           ` Joel Brobecker [this message]
     [not found]             ` <CAGWvnyna5R2AR0imAC4W+aCJXPFjwPm+45yP9VOgkO68T7sF7w@mail.gmail.com>
     [not found]               ` <OFC7611E7B.F19F366D-ON65257BE2.003745A0-65257BE2.00386093@in.ibm.com>
2013-09-17 18:38                 ` [RFA/ppc-aix] fix thread support breakage Tom Tromey
2013-08-29 21:03         ` Checked in: [RFA/ppc-aix] fix thread support breakage (was: "Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined.") Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130823133415.GD5221@adacore.com \
    --to=brobecker@adacore.com \
    --cc=Ulrich.Weigand@de.ibm.com \
    --cc=dje.gcc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=raunaq12@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox