From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12432 invoked by alias); 23 Aug 2013 13:34:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12416 invoked by uid 89); 23 Aug 2013 13:34:19 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.2 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 23 Aug 2013 13:34:19 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5F4F8116821; Fri, 23 Aug 2013 09:34:23 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NBK7PI--I9-Y; Fri, 23 Aug 2013 09:34:23 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1FFFA116807; Fri, 23 Aug 2013 09:34:23 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8BCE7C3DA9; Fri, 23 Aug 2013 06:34:15 -0700 (PDT) Date: Fri, 23 Aug 2013 13:34:00 -0000 From: Joel Brobecker To: David Edelsohn Cc: Raunaq 12 , GDB Patches , Mark Kettenis , Ulrich Weigand Subject: Re: [RFA/ppc-aix] fix thread support breakage (was: "Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined.") Message-ID: <20130823133415.GD5221@adacore.com> References: <20130822233234.GA13292@adacore.com> <20130823004837.GC5221@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-08/txt/msg00671.txt.bz2 > > gdb/ChangeLog: > > > > * rs6000-nat.c (rs6000_ptrace32): Cast "addr" to "uintptr_t" > > instead of "long long" in call to ptrace64. > > > > Tested on ppc-aix in full 32bit mode (both GDB and inferior are > > 32bit). I think the other scenario would be 64bit GDB debugging > > a 32bit inferior, but I don't have a 64bit compiler to try it. > > > > I'd like to commit this patch, unless there are comments/suggestions. > > LGTM. Thanks :) > Is there a testcase that can be added to the GDB testsuite to catch > this type of regression? All testcases involving thread support should reveal this type of failure. I cannot remember exactly how this patch was tested, but ISTR that it couldn't be tested through the official testsuite, for some reasons that were deemed reasonable... -- Joel