Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: walfred.tedeschi@intel.com
Cc: tromey@redhat.com, jan.kratochvil@redhat.com,
	mark.kettenis@xs4all.nl,        gdb-patches@sourceware.org,
	walfred.tedeschi@intel.com
Subject: Re: [PATCH 0/7] Intel(R) MPX registers support.
Date: Wed, 21 Aug 2013 14:33:00 -0000	[thread overview]
Message-ID: <201308211433.r7LEXaQ9000855@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <1377089148-11844-1-git-send-email-walfred.tedeschi@intel.com>	(message from Walfred Tedeschi on Wed, 21 Aug 2013 14:45:41 +0200)

> From: Walfred Tedeschi <walfred.tedeschi@intel.com>
> Date: Wed, 21 Aug 2013 14:45:41 +0200
> 
> This patch series adds support for the Intel(R) Memory Protection Extension
> MPX registers. Native and remote debugging are covered by this patch.
> 
> New registers are bound registers known as bnd register (bnd0...bnd3), a
> config register bndcfgu and a status register bndstatus.  Bound registers
> store pointer bounds, i.e. bound limits of a pointer.  Bndstatus and bndcfgu
> store information of the current status and configuration of other MPX 
> counterparts.  For more information [1][2].
> 
> Design notes:
> Bound register are represented in hardware as two fields of 64bits each,
> both in 64bit and 32bit mode. The fields are lower bound and upper bound.
> Upper bound value is a complement of one value of the upper limiting
> address. To take this into account the bnd0...bnd3 are created as 
> pseudo registers while the hardware values are stored on bnd0raw...bnd3raw.
> 
> Ok to commit?

Hi Walfred,

I had a quick look at the diffs.  Generally looks good.  There is an
issue though with how you handled the Linux-specific "orig_[er]ax"
fake register in the GDB interal register mapping.  Can you change
things such that it remains at the very hand of the internal register
file?

I may not be able to do a full review of the changes in the next 2.5
weeks.  A friendly reminder somewhere after Sep 9 wouldn't hurt ;).

Cheers,

Mark


  parent reply	other threads:[~2013-08-21 14:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21 12:46 Walfred Tedeschi
2013-08-21 12:46 ` [PATCH 4/7] MPX for amd64 Walfred Tedeschi
2013-08-21 12:46 ` [PATCH 3/7] Add MPX support for i386 Walfred Tedeschi
2013-08-21 12:46 ` [PATCH 2/7] Add MPX registers XML files Walfred Tedeschi
2013-08-21 12:46 ` [PATCH 7/7] Add MPX registers tests Walfred Tedeschi
2013-08-21 12:46 ` [PATCH 5/7] Add MPX support to gdbserver Walfred Tedeschi
2013-08-21 12:46 ` [PATCH 6/7] Add pretty-printer for MPX bnd registers Walfred Tedeschi
2013-08-21 12:46 ` [PATCH 1/7] Fix conditions in creating a bitfield Walfred Tedeschi
2013-08-21 14:33 ` Mark Kettenis [this message]
2013-08-21 16:25   ` [PATCH 0/7] Intel(R) MPX registers support Tedeschi, Walfred
2013-08-22  9:42     ` Tedeschi, Walfred
2013-08-23 13:30       ` Mark Kettenis
2013-08-23 13:40         ` Tedeschi, Walfred

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201308211433.r7LEXaQ9000855@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=tromey@redhat.com \
    --cc=walfred.tedeschi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox