From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: mircea.gherzan@intel.com, tromey@redhat.com,
gdb-patches@sourceware.org, markus.t.metzger@intel.com
Subject: Re: [PATCH] btrace: fix the non-native build
Date: Wed, 21 Aug 2013 13:59:00 -0000 [thread overview]
Message-ID: <20130821135907.GA7757@host2.jankratochvil.net> (raw)
In-Reply-To: <201308131503.r7DF31S2005371@glazunov.sibelius.xs4all.nl>
On Tue, 13 Aug 2013 17:03:01 +0200, Mark Kettenis wrote:
> > From: Mircea Gherzan <mircea.gherzan@intel.com>
> > Date: Tue, 13 Aug 2013 16:45:54 +0200
> >
> > When building on a non-Linux host for a Linux target, the build fails
> > because the linux-btrace object is not built/linked.
You should have included your config and error message.
> > 2013-08-09 Mircea Gherzan <mircea.gherzan@intel.com>
> >
> > gdb/
> > * configure.tgt: Add linux-btrace.o to gdb_target_obs for i386
> > and x86_64 Linux targets.
> > * config/i386/linux.mh (NATDEPFILES): Remove linux-btrace.o.
> > * config/i386/linux64.mh (NATDEPFILES): Remove linux-btrace.o.
>
> Nope. linux-btrace.c contains native code that should only ever be
> linked into a native GDB.
Technically linux-btrace.c defines:
linux_disable_btrace
linux_enable_btrace
linux_read_btrace
linux_supports_btrace
which are only used from amd64-linux-nat.c and i386-linux-nat.c which both are
also present in NATDEPFILES.
I have tested build on x86_64-unknown-netbsd5.1 (gcc70.fsffrance.org) for both
FSF GDB HEAD and for v4 patchset by Markus Metzger and it all builds fine.
(gdbserver is off-topic here, the patch does not modify any gdbserver-related
files.)
Jan
prev parent reply other threads:[~2013-08-21 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 14:47 Mircea Gherzan
2013-08-13 15:03 ` Mark Kettenis
2013-08-21 13:59 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821135907.GA7757@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=markus.t.metzger@intel.com \
--cc=mircea.gherzan@intel.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox