From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3200 invoked by alias); 21 Aug 2013 13:59:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3190 invoked by uid 89); 21 Aug 2013 13:59:14 -0000 X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 21 Aug 2013 13:59:13 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7LDxBF0027493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 21 Aug 2013 09:59:11 -0400 Received: from host2.jankratochvil.net (ovpn-116-54.ams2.redhat.com [10.36.116.54]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7LDx7Dl031719 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Wed, 21 Aug 2013 09:59:10 -0400 Date: Wed, 21 Aug 2013 13:59:00 -0000 From: Jan Kratochvil To: Mark Kettenis Cc: mircea.gherzan@intel.com, tromey@redhat.com, gdb-patches@sourceware.org, markus.t.metzger@intel.com Subject: Re: [PATCH] btrace: fix the non-native build Message-ID: <20130821135907.GA7757@host2.jankratochvil.net> References: <1376405154-13435-1-git-send-email-mircea.gherzan@intel.com> <201308131503.r7DF31S2005371@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201308131503.r7DF31S2005371@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-08/txt/msg00577.txt.bz2 On Tue, 13 Aug 2013 17:03:01 +0200, Mark Kettenis wrote: > > From: Mircea Gherzan > > Date: Tue, 13 Aug 2013 16:45:54 +0200 > > > > When building on a non-Linux host for a Linux target, the build fails > > because the linux-btrace object is not built/linked. You should have included your config and error message. > > 2013-08-09 Mircea Gherzan > > > > gdb/ > > * configure.tgt: Add linux-btrace.o to gdb_target_obs for i386 > > and x86_64 Linux targets. > > * config/i386/linux.mh (NATDEPFILES): Remove linux-btrace.o. > > * config/i386/linux64.mh (NATDEPFILES): Remove linux-btrace.o. > > Nope. linux-btrace.c contains native code that should only ever be > linked into a native GDB. Technically linux-btrace.c defines: linux_disable_btrace linux_enable_btrace linux_read_btrace linux_supports_btrace which are only used from amd64-linux-nat.c and i386-linux-nat.c which both are also present in NATDEPFILES. I have tested build on x86_64-unknown-netbsd5.1 (gcc70.fsffrance.org) for both FSF GDB HEAD and for v4 patchset by Markus Metzger and it all builds fine. (gdbserver is off-topic here, the patch does not modify any gdbserver-related files.) Jan