Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado),
	gdb-patches@sourceware.org, brobecker@adacore.com,
	luis_gustavo@mentor.com
Subject: Re: [PATCH 1/3] Fix ppc64 single step over atomic sequence testcase
Date: Fri, 02 Aug 2013 13:45:00 -0000	[thread overview]
Message-ID: <20130802234437.26615900@kryten> (raw)
In-Reply-To: <201308011554.r71Fs1r9008409@d06av02.portsmouth.uk.ibm.com>


Hi Uli,

> I think it might be best to just get rid of those .include statements;
> depending on an .inc file from another directory seems surprising.
> 
> It seems you only need it for the gdbasm_declare macro; since this
> file is ppc64 specific anyway, why don't you just hard-code the
> .opd generation in this source file?

Considering the issues we have had with getting the correct include
paths passed into the assembler, I tend to agree. It only saves a couple
of lines.

> Also, the assembler source file probably ought to keep the
> copyright header.   A comment why this test needs to use
> assembler source also would be good.

Thanks, will incorporate that into the next spin.

Anton


  reply	other threads:[~2013-08-02 13:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-29  7:39 Anton Blanchard
2013-07-29  7:40 ` [PATCH 2/3] Support up to 3 conditional branches in an atomic sequence Anton Blanchard
2013-08-01 15:39   ` Ulrich Weigand
2013-07-29  7:41 ` [PATCH 3/3] Add multiple branches to single step through atomic sequence testcase Anton Blanchard
2013-08-01 15:55   ` Ulrich Weigand
2013-07-30 17:15 ` [PATCH 1/3] Fix ppc64 single step over " Edjunior Barbosa Machado
2013-07-31 12:31   ` Anton Blanchard
2013-08-01 15:54     ` Ulrich Weigand
2013-08-02 13:45       ` Anton Blanchard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-03-31  2:59 Anton Blanchard
2014-03-31 15:38 ` Ulrich Weigand
2012-06-06  3:56 Anton Blanchard
2012-06-11 19:33 ` Joel Brobecker
2012-06-12 12:45   ` Anton Blanchard
2012-06-12 13:06     ` Luis Gustavo
2012-06-12 13:17       ` Joel Brobecker
2012-06-12 13:28         ` Luis Gustavo
2012-06-12 16:53           ` Edjunior Barbosa Machado
2012-06-13  0:46             ` Anton Blanchard
2012-06-13 14:00               ` Edjunior Barbosa Machado
2012-06-13 15:37                 ` Joel Brobecker
2012-07-16  6:23                   ` Anton Blanchard
2012-09-26 23:21                     ` Edjunior Barbosa Machado
2012-09-27 19:03                       ` Luis Gustavo
2012-09-28 10:16                     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130802234437.26615900@kryten \
    --to=anton@samba.org \
    --cc=brobecker@adacore.com \
    --cc=emachado@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis_gustavo@mentor.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox