From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-103978-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17594 invoked by alias); 2 Aug 2013 13:45:00 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 17531 invoked by uid 89); 2 Aug 2013 13:44:59 -0000
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.1
Received: from Unknown (HELO ozlabs.org) (203.10.76.45)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 02 Aug 2013 13:44:59 +0000
Received: from kryten (ppp121-44-170-211.lns20.syd7.internode.on.net [121.44.170.211])	(using SSLv3 with cipher DHE-RSA-AES128-SHA (128/128 bits))	(Client did not present a certificate)	by ozlabs.org (Postfix) with ESMTPSA id 5976A2C007E;	Fri,  2 Aug 2013 23:44:50 +1000 (EST)
Date: Fri, 02 Aug 2013 13:45:00 -0000
From: Anton Blanchard <anton@samba.org>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado), gdb-patches@sourceware.org, brobecker@adacore.com, luis_gustavo@mentor.com
Subject: Re: [PATCH 1/3] Fix ppc64 single step over atomic sequence testcase
Message-ID: <20130802234437.26615900@kryten>
In-Reply-To: <201308011554.r71Fs1r9008409@d06av02.portsmouth.uk.ibm.com>
References: <20130731223046.292f6a50@kryten>	<201308011554.r71Fs1r9008409@d06av02.portsmouth.uk.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-08/txt/msg00072.txt.bz2


Hi Uli,

> I think it might be best to just get rid of those .include statements;
> depending on an .inc file from another directory seems surprising.
> 
> It seems you only need it for the gdbasm_declare macro; since this
> file is ppc64 specific anyway, why don't you just hard-code the
> .opd generation in this source file?

Considering the issues we have had with getting the correct include
paths passed into the assembler, I tend to agree. It only saves a couple
of lines.

> Also, the assembler source file probably ought to keep the
> copyright header.   A comment why this test needs to use
> assembler source also would be good.

Thanks, will incorporate that into the next spin.

Anton