Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Apply fix to 15519 to 7.6 branch
Date: Mon, 24 Jun 2013 20:20:00 -0000	[thread overview]
Message-ID: <20130624193335.GB5326@adacore.com> (raw)
In-Reply-To: <yjt261x3iasf.fsf@ruffy.mtv.corp.google.com>

> I'd like to apply this to the 7.6 branch.
> Regression tested on amd64-linux, with/without Fission.
> 
> Ok to check in?
> 
> 2013-06-06  Doug Evans  <dje@google.com>
> 
> 	* gdb.cp/derivation.exp: Make tests have unique names.
> 
> 2013-06-05  Doug Evans  <dje@google.com>
> 	    Keith Seitz  <keiths@redhat.com>
> 
> 	PR 15519
> 	* cp-namespace.c (find_symbol_in_baseclass): Call
> 	cp_lookup_symbol_in_namespace instead of cp_lookup_symbol_namespace.
> 	Check result of call to lookup_symbol_static.
> 	Call lookup_static_symbol_aux unconditionally.
> 	Call check_typedef on base types before accessing them.
> 	(cp_lookup_nested_symbol): Fix comment.
> 
> 	testsuite/
> 	* gdb.cp/derivation2.cc: New file.
> 	* gdb.cp/derivation.cc (main): Call foo2.
> 	* gdb.cp/derivation.exp: Add tests for typedefs in another
> 	file, and when there's an active block.

Of course. You are much better qualified than I am to determine
the benefit / risk, so feel free to make those decisions (I think
that, for this area, Tom might be a good resource as well).

Just a quick reminder to update the release wiki page (I see you
already have a PR, which is going to make it less work :-) ).

Thank you!
-- 
Joel


      reply	other threads:[~2013-06-24 19:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-24 19:16 Doug Evans
2013-06-24 20:20 ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130624193335.GB5326@adacore.com \
    --to=brobecker@adacore.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox