From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17549 invoked by alias); 24 Jun 2013 19:33:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17540 invoked by uid 89); 24 Jun 2013 19:33:40 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 24 Jun 2013 19:33:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8C7C31C6595; Mon, 24 Jun 2013 15:33:38 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lH0SljbBL5GX; Mon, 24 Jun 2013 15:33:38 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5797A1C6492; Mon, 24 Jun 2013 15:33:38 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id B98BCCC339; Mon, 24 Jun 2013 12:33:35 -0700 (PDT) Date: Mon, 24 Jun 2013 20:20:00 -0000 From: Joel Brobecker To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Apply fix to 15519 to 7.6 branch Message-ID: <20130624193335.GB5326@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-06/txt/msg00676.txt.bz2 > I'd like to apply this to the 7.6 branch. > Regression tested on amd64-linux, with/without Fission. > > Ok to check in? > > 2013-06-06 Doug Evans > > * gdb.cp/derivation.exp: Make tests have unique names. > > 2013-06-05 Doug Evans > Keith Seitz > > PR 15519 > * cp-namespace.c (find_symbol_in_baseclass): Call > cp_lookup_symbol_in_namespace instead of cp_lookup_symbol_namespace. > Check result of call to lookup_symbol_static. > Call lookup_static_symbol_aux unconditionally. > Call check_typedef on base types before accessing them. > (cp_lookup_nested_symbol): Fix comment. > > testsuite/ > * gdb.cp/derivation2.cc: New file. > * gdb.cp/derivation.cc (main): Call foo2. > * gdb.cp/derivation.exp: Add tests for typedefs in another > file, and when there's an active block. Of course. You are much better qualified than I am to determine the benefit / risk, so feel free to make those decisions (I think that, for this area, Tom might be a good resource as well). Just a quick reminder to update the release wiki page (I see you already have a PR, which is going to make it less work :-) ). Thank you! -- Joel