From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: fix python-selftest.exp failure (Was: new FAIL python-selftest.exp in gdbserver mode [Re: [PATCH 18/28] check gdb_python_initialized everywhere])
Date: Mon, 17 Jun 2013 17:10:00 -0000 [thread overview]
Message-ID: <20130617170155.GA1831@host2.jankratochvil.net> (raw)
In-Reply-To: <87hagwd6k5.fsf_-_@fleche.redhat.com>
On Mon, 17 Jun 2013 18:51:22 +0200, Tom Tromey wrote:
> The bug is that the selftest code doesn't work in this situation. It
> never has.
>
> This patch fixes the problem by pushing the needed check into
> do_self_tests. This helps prevent the problem in the future.
That looks fine to me, you wrote lib/selftest-support.exp anyway.
Thanks,
Jan
next prev parent reply other threads:[~2013-06-17 17:02 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 14:32 [0/27] RFC: fix reports from the CPython checker Tom Tromey
2013-04-19 14:32 ` Eli Zaretskii
2013-04-19 18:08 ` Tom Tromey
2013-04-19 14:34 ` Tom Tromey
2013-04-19 14:36 ` [PATCH 03/28] PyObject_GetAttrString returns a new ref Tom Tromey
2013-04-19 14:36 ` [0/27] RFC: fix reports from the CPython checker Tom Tromey
2013-04-19 14:36 ` [PATCH 01/28] introduce CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF and use it Tom Tromey
2013-05-15 15:57 ` Pedro Alves
2013-05-20 20:08 ` Tom Tromey
2013-05-21 0:20 ` Pedro Alves
2013-04-19 14:37 ` [PATCH 04/28] add missing decref in before_prompt_hook Tom Tromey
2013-04-19 14:38 ` [PATCH 05/28] py-cmd.c error-checking bug fix Tom Tromey
2013-05-15 16:01 ` Pedro Alves
2013-05-15 16:20 ` Tom Tromey
2013-05-15 16:29 ` Pedro Alves
2013-04-19 14:38 ` [PATCH 06/28] fix py-evtregistry.c refcount bug Tom Tromey
2013-04-23 0:23 ` Tom Tromey
2013-04-19 14:39 ` [PATCH 07/28] remove unused declaration Tom Tromey
2013-04-19 14:40 ` [PATCH 08/28] use CPYCHECKER_SETS_EXCEPTION Tom Tromey
2013-04-19 14:41 ` [PATCH 10/28] add decref to cmdpy_init Tom Tromey
2013-04-19 14:41 ` [PATCH 11/28] use iterator protocol and avoid refcount bugs Tom Tromey
2013-04-19 14:41 ` [PATCH 09/28] introduce and use CPYCHECKER_NEGATIVE_RESULT_SETS_EXCEPTION Tom Tromey
2013-04-19 14:42 ` [PATCH 12/28] add decref in evpy_emit_event Tom Tromey
2013-04-19 14:43 ` [PATCH 13/28] fix get_addr_from_python Tom Tromey
2013-04-19 14:43 ` [PATCH 15/28] fix bug in gdbpy_initialize_event_generic Tom Tromey
2013-04-19 14:43 ` [PATCH 14/28] add gdb_assert_not_reached Tom Tromey
2013-04-19 14:44 ` [PATCH 16/28] reference count in bpfinishpy_out_of_scope Tom Tromey
2013-04-19 14:47 ` [PATCH 17/28] convert python init functions to do error-checking Tom Tromey
2013-04-19 15:40 ` [PATCH 18/28] check gdb_python_initialized everywhere Tom Tromey
2013-04-23 1:09 ` Tom Tromey
2013-05-07 17:57 ` Doug Evans
2013-05-07 18:06 ` Doug Evans
2013-05-07 18:13 ` Tom Tromey
2013-05-15 16:43 ` Pedro Alves
2013-05-15 17:39 ` Remove my name from a couple tests (Re: [PATCH 18/28] check gdb_python_initialized everywhere) Pedro Alves
2013-05-07 18:06 ` [PATCH 18/28] check gdb_python_initialized everywhere Tom Tromey
2013-05-21 8:22 ` new FAIL python-selftest.exp in gdbserver mode [Re: [PATCH 18/28] check gdb_python_initialized everywhere] Jan Kratochvil
2013-06-17 16:59 ` RFC: fix python-selftest.exp failure (Was: new FAIL python-selftest.exp in gdbserver mode [Re: [PATCH 18/28] check gdb_python_initialized everywhere]) Tom Tromey
2013-06-17 17:10 ` Jan Kratochvil [this message]
2013-06-18 14:25 ` RFC: fix python-selftest.exp failure Tom Tromey
2013-04-19 16:20 ` [PATCH 19/28] add missing decref in py-param.c Tom Tromey
2013-04-19 16:34 ` [PATCH 20/28] make set_sal follow negative result convention Tom Tromey
2013-04-19 16:44 ` [PATCH 21/28] fix refcounting in gdbpy_run_events Tom Tromey
2013-04-19 16:55 ` [PATCH 22/28] remove erroneous incref from gdbpy_initialize_py_events Tom Tromey
2013-04-19 17:15 ` [PATCH 23/28] use explicit decrefs rather than cleanups in some cases Tom Tromey
2013-04-19 17:46 ` [PATCH 24/28] introduce gdb_pymodule_addobject Tom Tromey
2013-05-21 7:58 ` [patch] Compilation regression with python-2.6 [Re: [PATCH 24/28] introduce gdb_pymodule_addobject] Jan Kratochvil
2013-05-21 13:30 ` Tom Tromey
2013-05-21 15:02 ` [commit] " Jan Kratochvil
2013-05-21 16:05 ` Pedro Alves
2013-05-21 16:14 ` Jan Kratochvil
2013-05-21 16:24 ` Pedro Alves
2013-05-21 16:36 ` Tom Tromey
2013-05-21 16:48 ` Pedro Alves
2013-05-21 17:32 ` Tom Tromey
2013-05-21 20:56 ` [COMMIT] py_decref: Don't check for NULL before calling Py_DECREF. (was: Re: [patch] Compilation regression with python-2.6) Pedro Alves
2013-05-21 20:55 ` [COMMIT] Centralize workaround for Python 2.6's Py_DECREF. (Re: " Pedro Alves
2013-06-03 12:50 ` Python 2.4 compile failure (Re: [PATCH 24/28] introduce gdb_pymodule_addobject) Ulrich Weigand
2013-06-03 16:06 ` Tom Tromey
2013-06-03 16:54 ` Ulrich Weigand
2013-06-05 17:31 ` Tom Tromey
2013-04-19 17:49 ` [PATCH 25/28] some py-frame.c changes to make the checker work better Tom Tromey
2013-04-19 17:50 ` [PATCH 26/28] fix refcount bug in typy_fields Tom Tromey
2013-04-19 17:52 ` [PATCH 27/28] rearrange for some clarity in valpy_get_dynamic_type Tom Tromey
2013-04-19 17:59 ` [PATCH 28/28] fix refcount bug in search_pp_list Tom Tromey
2013-05-20 20:06 ` [0/27] RFC: fix reports from the CPython checker Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617170155.GA1831@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox