From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13869 invoked by alias); 17 Jun 2013 17:02:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13847 invoked by uid 89); 17 Jun 2013 17:02:02 -0000 X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 17 Jun 2013 17:02:02 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5HH20EA021003 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 17 Jun 2013 13:02:00 -0400 Received: from host2.jankratochvil.net (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5HH1uxo004995 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 17 Jun 2013 13:01:59 -0400 Date: Mon, 17 Jun 2013 17:10:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFC: fix python-selftest.exp failure (Was: new FAIL python-selftest.exp in gdbserver mode [Re: [PATCH 18/28] check gdb_python_initialized everywhere]) Message-ID: <20130617170155.GA1831@host2.jankratochvil.net> References: <87ehe638ww.fsf@fleche.redhat.com> <87vc7iy49l.fsf@fleche.redhat.com> <87zjwqqv2u.fsf@fleche.redhat.com> <20130521082202.GA1789@host2.jankratochvil.net> <87hagwd6k5.fsf_-_@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87hagwd6k5.fsf_-_@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-06/txt/msg00384.txt.bz2 On Mon, 17 Jun 2013 18:51:22 +0200, Tom Tromey wrote: > The bug is that the selftest code doesn't work in this situation. It > never has. > > This patch fixes the problem by pushing the needed check into > do_self_tests. This helps prevent the problem in the future. That looks fine to me, you wrote lib/selftest-support.exp anyway. Thanks, Jan