From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: arnez@linux.vnet.ibm.com
Cc: gdb-patches@sourceware.org, Ulrich.Weigand@de.ibm.com
Subject: Re: [PATCH v3 3/3] Dynamic core regset sections support
Date: Wed, 12 Jun 2013 16:06:00 -0000 [thread overview]
Message-ID: <201306121521.r5CFLvl9024858@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <8738sngy5e.fsf@br87z6lw.de.ibm.com> (message from Andreas Arnez on Wed, 12 Jun 2013 17:13:33 +0200)
> From: Andreas Arnez <arnez@linux.vnet.ibm.com>
> Date: Wed, 12 Jun 2013 17:13:33 +0200
>
> Rework the handling of core file register note sections. So far the
> target-dependent code provided a static list of supported register
> note sections via set_gdbarch_core_regset_sections. This patch
> replaces the static list by a target-dependent iterator function which
> can be set with set_gdbarch_iterate_over_regset_sections. Only those
> architectures that have been using set_gdbarch_core_regset_sections
> are affected by this change.
>
> The patch is needed on newer z/Architecture systems for correct gcore
> handling. With the static approach, gcore always writes the TDB
> regset into the core file, even if the TDB registers are currently
> invalid. The new iterator omits the TDB in this case.
Sorry, but I really don't like the obfuscation that this diff brings
to the amd64 & i186 Linux targets. Is there really no other way to
this? Is it really that bad to write out the invalid TDB registers?
If GDB recognizes them as invalid, this shouldn't be a big issue
should it?
next prev parent reply other threads:[~2013-06-12 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 15:12 [RFA PATCH v3 0/3] Add TDB regset support Andreas Arnez
2013-06-12 15:12 ` [PATCH v3 1/3] S/390 regmap rework Andreas Arnez
2013-06-12 15:13 ` [PATCH v3 2/3] Add TDB regset Andreas Arnez
2013-06-12 15:23 ` [PATCH v3 3/3] Dynamic core regset sections support Andreas Arnez
2013-06-12 16:06 ` Mark Kettenis [this message]
2013-06-13 9:32 ` Andreas Arnez
2013-06-13 11:02 ` Pedro Alves
2013-06-13 12:23 ` Andreas Arnez
2013-06-13 14:44 ` Pedro Alves
2013-06-13 17:36 ` Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306121521.r5CFLvl9024858@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox