From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13036 invoked by alias); 12 Jun 2013 15:23:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12990 invoked by uid 89); 12 Jun 2013 15:23:41 -0000 X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 12 Jun 2013 15:23:40 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id r5CFLvLG029536; Wed, 12 Jun 2013 17:21:57 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id r5CFLvl9024858; Wed, 12 Jun 2013 17:21:57 +0200 (CEST) Date: Wed, 12 Jun 2013 16:06:00 -0000 Message-Id: <201306121521.r5CFLvl9024858@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: arnez@linux.vnet.ibm.com CC: gdb-patches@sourceware.org, Ulrich.Weigand@de.ibm.com In-reply-to: <8738sngy5e.fsf@br87z6lw.de.ibm.com> (message from Andreas Arnez on Wed, 12 Jun 2013 17:13:33 +0200) Subject: Re: [PATCH v3 3/3] Dynamic core regset sections support References: <877ghzmkmj.fsf@br87z6lw.de.ibm.com> <8738sngy5e.fsf@br87z6lw.de.ibm.com> X-SW-Source: 2013-06/txt/msg00287.txt.bz2 > From: Andreas Arnez > Date: Wed, 12 Jun 2013 17:13:33 +0200 > > Rework the handling of core file register note sections. So far the > target-dependent code provided a static list of supported register > note sections via set_gdbarch_core_regset_sections. This patch > replaces the static list by a target-dependent iterator function which > can be set with set_gdbarch_iterate_over_regset_sections. Only those > architectures that have been using set_gdbarch_core_regset_sections > are affected by this change. > > The patch is needed on newer z/Architecture systems for correct gcore > handling. With the static approach, gcore always writes the TDB > regset into the core file, even if the TDB registers are currently > invalid. The new iterator omits the TDB in this case. Sorry, but I really don't like the obfuscation that this diff brings to the amd64 & i186 Linux targets. Is there really no other way to this? Is it really that bad to write out the invalid TDB registers? If GDB recognizes them as invalid, this shouldn't be a big issue should it?