Re: [RFA 3/7 take 2] New gdbserver functionality

[Gary Benson <gbenson@redhat.com>]

Pedro Alves wrote:
> On 05/16/2013 03:48 PM, Gary Benson wrote:
> 
> > +	  sep = strchr (annex, '=');
> > +	  if (!sep)
> 
> Please write
> 
>          if (sep == NULL)
> 
> There are more instances of this in the patch.
> 
> > +	    break;
> > +
> > +	  len = sep - annex;
> > +	  if (len == 5 && !strncmp (annex, "start", 5))
> 
> strncmp does not return a boolean.  Please write:
> 
> > +	  if (len == 5 && strncmp (annex, "start", 5) == 0)
> 
> 
> > +	  else if (len == 4 && !strncmp (annex, "prev", 4))
> 
> Ditto.

I have updated the patch with these changes.

> There should be a NEWS entry for the new RSP feature too though.

How does this look?

+* New features in the GDB remote stub, GDBserver
+
+  ** GDBserver now supports the passing of an argument list in the
+     annex field of qXfer:libraries-svr4:read.  The remote stub
+     reports support for this argument list to gdb's qSupported query.
+

Thanks,
Gary