From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-102045-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11837 invoked by alias); 30 May 2013 09:38:47 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 11808 invoked by uid 89); 30 May 2013 09:38:43 -0000
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED autolearn=ham version=3.3.1
Received: from gbenson.demon.co.uk (HELO blade.nx) (80.177.220.214)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 30 May 2013 09:38:41 +0000
Received: by blade.nx (Postfix, from userid 500)	id 830FE263F7C; Thu, 30 May 2013 10:38:39 +0100 (BST)
Date: Thu, 30 May 2013 09:38:00 -0000
From: Gary Benson <gbenson@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 3/7 take 2] New gdbserver functionality
Message-ID: <20130530093839.GC5357@blade.nx>
Mail-Followup-To: Pedro Alves <palves@redhat.com>,	Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
References: <20130524074613.GA4602@blade.nx> <51A64DEE.6070307@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51A64DEE.6070307@redhat.com>
X-SW-Source: 2013-05/txt/msg01051.txt.bz2

Pedro Alves wrote:
> On 05/16/2013 03:48 PM, Gary Benson wrote:
> 
> > +	  sep = strchr (annex, '=');
> > +	  if (!sep)
> 
> Please write
> 
>          if (sep == NULL)
> 
> There are more instances of this in the patch.
> 
> > +	    break;
> > +
> > +	  len = sep - annex;
> > +	  if (len == 5 && !strncmp (annex, "start", 5))
> 
> strncmp does not return a boolean.  Please write:
> 
> > +	  if (len == 5 && strncmp (annex, "start", 5) == 0)
> 
> 
> > +	  else if (len == 4 && !strncmp (annex, "prev", 4))
> 
> Ditto.

I have updated the patch with these changes.

> There should be a NEWS entry for the new RSP feature too though.

How does this look?

+* New features in the GDB remote stub, GDBserver
+
+  ** GDBserver now supports the passing of an argument list in the
+     annex field of qXfer:libraries-svr4:read.  The remote stub
+     reports support for this argument list to gdb's qSupported query.
+

Thanks,
Gary