From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Checked in: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]
Date: Tue, 21 May 2013 05:43:00 -0000 [thread overview]
Message-ID: <20130521054334.GV4017@adacore.com> (raw)
In-Reply-To: <87ehd1ogh9.fsf@fleche.redhat.com>
> Joel> Do you see something obviously wrong with the attached patch?
> Joel> I haven't tested it yet, and I am not sure how much I can test it,
> Joel> given that old-style renamings have been replaced 6 years ago.
> Joel> I was looking at the option of removing support for them, but
> Joel> I actually know of some users still using an ancient version
> Joel> of the compiler but with a new version of the debugger...
>
> For some reason I thought the function needed to leave a dangling
> cleanup, but I see now I was mistaken.
> It looks good to me.
Cool, thanks! Attached is what I checked in, after a round of testing on
x86_64-linux.
gdb/ChangeLog:
* ada-lang.c (old_renaming_is_invisible): Fix cleanup leak.
Thanks again for pointing this cleanup leak out.
--
Joel
next prev parent reply other threads:[~2013-05-21 5:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 19:46 [RFC] Cleanup for make_source_files_completion_list Keith Seitz
2013-05-09 20:58 ` Tom Tromey
2013-05-09 23:45 ` Doug Evans
2013-05-13 18:42 ` Keith Seitz
2013-05-13 21:11 ` Keith Seitz
2013-05-15 17:36 ` Keith Seitz
2013-05-15 19:32 ` [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list] Keith Seitz
2013-05-15 20:01 ` Tom Tromey
2013-05-15 21:22 ` Keith Seitz
2013-05-15 22:33 ` Sergio Durigan Junior
2013-05-15 23:47 ` Keith Seitz
2013-05-16 0:21 ` Sergio Durigan Junior
2013-05-16 0:27 ` Stan Shebs
2013-05-16 9:38 ` Pedro Alves
2013-05-16 5:30 ` Joel Brobecker
2013-05-16 5:49 ` Joel Brobecker
2013-05-16 15:41 ` Keith Seitz
2013-05-17 5:14 ` Joel Brobecker
2013-05-17 16:27 ` Tom Tromey
2013-05-20 5:28 ` Joel Brobecker
2013-05-20 14:47 ` Tom Tromey
2013-05-21 5:43 ` Joel Brobecker [this message]
2013-05-21 5:44 ` Checked in: " Joel Brobecker
2013-05-16 5:53 ` Sergio Durigan Junior
2013-05-16 6:00 ` Joel Brobecker
2013-05-16 9:19 ` Pedro Alves
2013-05-16 9:26 ` Joel Brobecker
2013-05-16 10:18 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130521054334.GV4017@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox