From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7955 invoked by alias); 21 May 2013 05:43:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7946 invoked by uid 89); 21 May 2013 05:43:43 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 21 May 2013 05:43:42 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5C94E1C6140; Tue, 21 May 2013 01:43:41 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id igcMoU-ZGcrG; Tue, 21 May 2013 01:43:41 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EDF8D2EA5E; Tue, 21 May 2013 01:43:40 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1B081C376B; Tue, 21 May 2013 09:43:35 +0400 (RET) Date: Tue, 21 May 2013 05:43:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Checked in: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list] Message-ID: <20130521054334.GV4017@adacore.com> References: <5193E2DC.5000200@redhat.com> <51941E85.8010104@redhat.com> <20130516053008.GA5555@adacore.com> <20130516054906.GB5555@adacore.com> <5194FE2A.7000205@redhat.com> <20130517051435.GC4017@adacore.com> <87ehd5r2qr.fsf@fleche.redhat.com> <20130520052818.GK4017@adacore.com> <87ehd1ogh9.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ehd1ogh9.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-05/txt/msg00755.txt.bz2 > Joel> Do you see something obviously wrong with the attached patch? > Joel> I haven't tested it yet, and I am not sure how much I can test it, > Joel> given that old-style renamings have been replaced 6 years ago. > Joel> I was looking at the option of removing support for them, but > Joel> I actually know of some users still using an ancient version > Joel> of the compiler but with a new version of the debugger... > > For some reason I thought the function needed to leave a dangling > cleanup, but I see now I was mistaken. > It looks good to me. Cool, thanks! Attached is what I checked in, after a round of testing on x86_64-linux. gdb/ChangeLog: * ada-lang.c (old_renaming_is_invisible): Fix cleanup leak. Thanks again for pointing this cleanup leak out. -- Joel