From: Mike Frysinger <vapier@gentoo.org>
To: "Jayant R. Sonar" <Jayant.Sonar@kpitcummins.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Kaushik Phatak <Kaushik.Phatak@kpitcummins.com>
Subject: Re: [PATCH ARM] Fixing problem of 32bit multiplication instruction 'smull'
Date: Thu, 16 May 2013 15:55:00 -0000 [thread overview]
Message-ID: <201305161154.53791.vapier@gentoo.org> (raw)
In-Reply-To: <C013F7BFDC93F047B111833D343777BD6B42179E@KCHJEXMB03.kpit.com>
[-- Attachment #1: Type: Text/Plain, Size: 727 bytes --]
On Thursday 16 May 2013 11:13:06 Jayant R. Sonar wrote:
> Hello Mike,
>
> Thanks again for reviewing this patch as well.
>
> >> could you make that into a test case ? :)
>
> I really don't have a test case in C form as of now.
you posted a small asm snippet. seems like that'd be sufficient ?
in the Blackfin sim tests, i often just have the script exit 0 or 1 depending
on the result. if a specific insn is not calculating the right value (or is
hitting an error it shouldn't), seems like you could do the same ?
# pseudo code as my arm asm is not strong
r1 = <known good value>
r2 = <some input known to trigger bug>
r3 = <diff input>
r4 = r2 * r3
if r1 != r4
bx fail
bx pass
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-05-16 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 13:16 Jayant R. Sonar
[not found] ` <201305151210.11573.vapier@gentoo.org>
2013-05-16 15:14 ` Jayant R. Sonar
2013-05-16 15:55 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305161154.53791.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=Jayant.Sonar@kpitcummins.com \
--cc=Kaushik.Phatak@kpitcummins.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox