Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/5] Convert rs->support_vCont_t to a struct
Date: Tue, 14 May 2013 19:10:00 -0000	[thread overview]
Message-ID: <20130514191040.13213.71985.stgit@brno.lan> (raw)
In-Reply-To: <20130514191026.13213.39574.stgit@brno.lan>

Convert the 'support_vCont_t' int field to a struct, in preparation
for adding more fields to it.

v3:
 - s/support/supports/
 - struct renamed.
 - comments tweaked.

gdb/
2013-05-14  Yao Qi  <yao@codesourcery.com>
	    Pedro Alves  <palves@redhat.com>

	* remote.c (struct vCont_action_support): New struct.
	(struct remote_state) <support_vCont_t>: Remove field.
	<vCont_actions_support>: New field.
	(remote_vcont_probe, remote_stop_ns): Update.
---
 gdb/remote.c |   21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/gdb/remote.c b/gdb/remote.c
index 7cae940..5d3950b 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -251,6 +251,17 @@ static struct cmd_list_element *remote_cmdlist;
 static struct cmd_list_element *remote_set_cmdlist;
 static struct cmd_list_element *remote_show_cmdlist;
 
+/* Stub vCont actions support.
+
+   Each field is a boolean flag indicating whether the stub reports
+   support for the corresponding action.  */
+
+struct vCont_action_support
+{
+  /* vCont;t */
+  int t;
+};
+
 /* Description of the remote protocol state for the currently
    connected target.  This is per-target state, and independent of the
    selected architecture.  */
@@ -308,8 +319,8 @@ struct remote_state
   /* True if the stub reports support for non-stop mode.  */
   int non_stop_aware;
 
-  /* True if the stub reports support for vCont;t.  */
-  int support_vCont_t;
+  /* The status of the stub support for the various vCont actions.  */
+  struct vCont_action_support supports_vCont;
 
   /* True if the stub reports support for conditional tracepoints.  */
   int cond_tracepoints;
@@ -4641,7 +4652,7 @@ remote_vcont_probe (struct remote_state *rs)
       support_S = 0;
       support_c = 0;
       support_C = 0;
-      rs->support_vCont_t = 0;
+      rs->supports_vCont.t = 0;
       while (p && *p == ';')
 	{
 	  p++;
@@ -4654,7 +4665,7 @@ remote_vcont_probe (struct remote_state *rs)
 	  else if (*p == 'C' && (*(p + 1) == ';' || *(p + 1) == 0))
 	    support_C = 1;
 	  else if (*p == 't' && (*(p + 1) == ';' || *(p + 1) == 0))
-	    rs->support_vCont_t = 1;
+	    rs->supports_vCont.t = 1;
 
 	  p = strchr (p, ';');
 	}
@@ -5003,7 +5014,7 @@ remote_stop_ns (ptid_t ptid)
   if (remote_protocol_packets[PACKET_vCont].support == PACKET_SUPPORT_UNKNOWN)
     remote_vcont_probe (rs);
 
-  if (!rs->support_vCont_t)
+  if (!rs->supports_vCont.t)
     error (_("Remote server does not support stopping threads"));
 
   if (ptid_equal (ptid, minus_one_ptid)


  parent reply	other threads:[~2013-05-14 19:10 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-14 19:10 [PATCH 0/5 V3] target-assisted range stepping Pedro Alves
2013-05-14 19:10 ` [PATCH 1/5] Factor out in-stepping-range checks Pedro Alves
2013-05-14 19:37   ` Tom Tromey
2013-05-14 19:10 ` [PATCH 3/5] range stepping: gdb Pedro Alves
2013-05-14 19:46   ` Eli Zaretskii
2013-05-15 10:23     ` Pedro Alves
2013-05-15 11:22       ` Eli Zaretskii
2013-05-15 12:39         ` Pedro Alves
2013-05-15 13:46           ` Eli Zaretskii
2013-05-15 13:58             ` Pedro Alves
2013-05-15 18:20               ` Pedro Alves
2013-05-16  6:08                 ` Eli Zaretskii
2013-05-20 18:43                   ` Pedro Alves
2013-05-20 19:05                     ` Eli Zaretskii
2013-05-23  0:47                     ` Yao Qi
2013-05-23 17:22                       ` Pedro Alves
2013-05-14 19:10 ` [PATCH 4/5] range stepping: gdbserver (x86 GNU/Linux) Pedro Alves
2013-05-14 19:47   ` Eli Zaretskii
2013-05-14 20:14   ` Tom Tromey
2013-05-23 17:44     ` Pedro Alves
2013-05-24 11:33       ` Pedro Alves
2013-05-15 12:14   ` Yao Qi
2013-05-20 18:01     ` Pedro Alves
2013-05-23  0:56   ` Yao Qi
2013-05-23 17:26     ` Pedro Alves
2013-05-14 19:10 ` Pedro Alves [this message]
2013-05-14 19:40   ` [PATCH 2/5] Convert rs->support_vCont_t to a struct Tom Tromey
2013-05-14 19:11 ` [PATCH 5/5] range stepping: tests Pedro Alves
2013-05-22 14:32   ` Yao Qi
2013-05-23 17:34     ` Pedro Alves
2013-05-23 18:03     ` Pedro Alves
2013-05-24  2:27       ` Yao Qi
2013-05-24  9:45         ` Pedro Alves
2013-05-24  9:57           ` Yao Qi
2013-05-14 20:21 ` [PATCH 0/5 V3] target-assisted range stepping Tom Tromey
2013-05-23 17:44   ` Pedro Alves
2013-05-23  1:02 ` Yao Qi
2013-05-23 17:46   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130514191040.13213.71985.stgit@brno.lan \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox