Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pavel.v.chupin@gmail.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/configure: Replace hardcoded -ldl with check based on dlfcn.h availability
Date: Mon, 06 May 2013 12:30:00 -0000	[thread overview]
Message-ID: <201305061230.r46CU0P4006086@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <CANwJu18MP86hi3etqskPSR3Pt6tPEZCSndzW2No_9ZHEig0AHQ@mail.gmail.com>	(message from Pavel Chupin on Mon, 6 May 2013 15:28:14 +0400)

> Date: Mon, 6 May 2013 15:28:14 +0400
> From: Pavel Chupin <pavel.v.chupin@gmail.com>
> 
> On Wed, Apr 17, 2013 at 3:21 PM, Pavel Chupin <pavel.v.chupin@gmail.com> wrote:
> > Hi,
> > Attached patch adds check for dlfcn.h header availability before
> > adding -ldl to some configure commands. Otherwise on some
> > configuration -ldl is added unconditionally even though it's not
> > required and gdb is configured without ELF support due to failed link.
> >
> > Issue is found on mingw gdb build for Android.
> >
> > gdb/ChangeLog entry:
> > 2013-04-16  Pavel Chupin  <pavel.v.chupin@intel.com>
> >
> >         Replace hardcoded -ldl with check based on dlfcn.h availability
> >         * configure.ac: Add dlfcn.h check and DLOPEN_LIBS def.
> >         * acinclude.m4: Use DLOPEN_LIBS instead of hardcode.
> >         * configure: Regenerate.
> >
> 
> Ping

The fix isn't quite right.  OpenBSD for example has <dlfcn.h> but no
libdl; dlopen(3) and friends live in libc.


  reply	other threads:[~2013-05-06 12:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-17 16:39 Pavel Chupin
2013-05-06 11:28 ` Pavel Chupin
2013-05-06 12:30   ` Mark Kettenis [this message]
2013-05-07 10:02     ` Pavel Chupin
2013-05-14 19:00       ` Tom Tromey
2013-05-14 19:24         ` Mark Kettenis
2013-05-16  6:47           ` Pavel Chupin
2013-05-16 14:04             ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201305061230.r46CU0P4006086@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=pavel.v.chupin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox