From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20997 invoked by alias); 6 May 2013 12:30:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20986 invoked by uid 89); 6 May 2013 12:30:05 -0000 X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 06 May 2013 12:30:04 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id r46CU0at028054; Mon, 6 May 2013 14:30:00 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id r46CU0P4006086; Mon, 6 May 2013 14:30:00 +0200 (CEST) Date: Mon, 06 May 2013 12:30:00 -0000 Message-Id: <201305061230.r46CU0P4006086@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: pavel.v.chupin@gmail.com CC: gdb-patches@sourceware.org In-reply-to: (message from Pavel Chupin on Mon, 6 May 2013 15:28:14 +0400) Subject: Re: [PATCH] gdb/configure: Replace hardcoded -ldl with check based on dlfcn.h availability References: X-SW-Source: 2013-05/txt/msg00111.txt.bz2 > Date: Mon, 6 May 2013 15:28:14 +0400 > From: Pavel Chupin > > On Wed, Apr 17, 2013 at 3:21 PM, Pavel Chupin wrote: > > Hi, > > Attached patch adds check for dlfcn.h header availability before > > adding -ldl to some configure commands. Otherwise on some > > configuration -ldl is added unconditionally even though it's not > > required and gdb is configured without ELF support due to failed link. > > > > Issue is found on mingw gdb build for Android. > > > > gdb/ChangeLog entry: > > 2013-04-16 Pavel Chupin > > > > Replace hardcoded -ldl with check based on dlfcn.h availability > > * configure.ac: Add dlfcn.h check and DLOPEN_LIBS def. > > * acinclude.m4: Use DLOPEN_LIBS instead of hardcode. > > * configure: Regenerate. > > > > Ping The fix isn't quite right. OpenBSD for example has but no libdl; dlopen(3) and friends live in libc.