From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [ANNOUNCEMENT] GDB 7.6 released!
Date: Mon, 29 Apr 2013 09:53:00 -0000 [thread overview]
Message-ID: <20130428073805.GU3525@adacore.com> (raw)
In-Reply-To: <837gjotnc9.fsf@gnu.org>
> > The offending incomplete type is 'enum errors'.
>
> Any reason not to include exceptions.h in utils.h, to avoid these
> warnings?
No objection from me. We'd then be able to remove the partial
declaration of that enum.
A few additional thoughts:
I am wondering why we are not seeing this on other platforms...
utils.c:throw_perror_with_name doesn't appear to be used anywhere except
in utils.c:perror_with_name, which is nothing more than a wrapper where
errcode is set to GENERIC_ERROR. I am wondering if we want to keep that
function around, or either make the function static, or inline its code
in perror_with_name...
I'd probably investigate why and when the function was introduced
before making a decision, but I am running out of time for today...
--
Joel
next prev parent reply other threads:[~2013-04-28 7:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <announce.20130426140741.GA13837@adacore.com>
[not found] ` <83k3nptk18.fsf@gnu.org>
2013-04-28 22:59 ` Eli Zaretskii
2013-04-29 9:53 ` Joel Brobecker [this message]
2013-04-29 12:48 ` Eli Zaretskii
2013-04-29 14:37 ` Joel Brobecker
2013-04-29 15:24 ` Andreas Schwab
2013-05-05 19:44 ` Jan Kratochvil
2013-05-06 10:32 ` Joel Brobecker
2013-05-06 16:19 ` Eli Zaretskii
2013-05-06 18:19 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130428073805.GU3525@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox