From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30805 invoked by alias); 28 Apr 2013 07:38:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30794 invoked by uid 89); 28 Apr 2013 07:38:13 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 28 Apr 2013 07:38:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6067E1C7F72; Sun, 28 Apr 2013 03:38:11 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Z1o0hS-9We+8; Sun, 28 Apr 2013 03:38:11 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D19141C79F5; Sun, 28 Apr 2013 03:38:10 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 61E9FC2379; Sun, 28 Apr 2013 00:38:05 -0700 (PDT) Date: Mon, 29 Apr 2013 09:53:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [ANNOUNCEMENT] GDB 7.6 released! Message-ID: <20130428073805.GU3525@adacore.com> References: <83k3nptk18.fsf@gnu.org> <837gjotnc9.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <837gjotnc9.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-04/txt/msg00851.txt.bz2 > > The offending incomplete type is 'enum errors'. > > Any reason not to include exceptions.h in utils.h, to avoid these > warnings? No objection from me. We'd then be able to remove the partial declaration of that enum. A few additional thoughts: I am wondering why we are not seeing this on other platforms... utils.c:throw_perror_with_name doesn't appear to be used anywhere except in utils.c:perror_with_name, which is nothing more than a wrapper where errcode is set to GENERIC_ERROR. I am wondering if we want to keep that function around, or either make the function static, or inline its code in perror_with_name... I'd probably investigate why and when the function was introduced before making a decision, but I am running out of time for today... -- Joel