From: Samuel Thibault <samuel.thibault@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, thomas@schwinge.name, bug-hurd@gnu.org
Subject: Re: [PATCH,HURD] Fix reading core
Date: Fri, 26 Apr 2013 17:50:00 -0000 [thread overview]
Message-ID: <20130426111926.GX5825@type.youpi.perso.aquilenet.fr> (raw)
In-Reply-To: <20130409234117.GC24389@adacore.com>
Joel Brobecker, le Tue 09 Apr 2013 16:41:17 -0700, a écrit :
> > The i386 GNU/Hurd ELF core format actually follows the uaccess gregset_t
> > array format, not the Mach thread state format. This fixes gdb reading
> > it.
> >
> > * gdb/i386gnu-nat.c (CREG_OFFSET): New macro.
> > (creg_offset): New array.
> > (CREG_ADDR): Use creg_offset instead of reg_offset.
>
> Did anyone review this? I don't know GNU/Hurd, but the patch looks
> very plausible.
>
> Do you have write access to the GDB repository?
I don't.
> If not, do you have copyright assignment papers on file?
It's on file now.
Samuel
next prev parent reply other threads:[~2013-04-26 11:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 2:01 Samuel Thibault
2013-04-10 11:33 ` Joel Brobecker
2013-04-11 2:44 ` Thomas Schwinge
2013-04-11 3:55 ` Samuel Thibault
2013-04-11 14:08 ` Thomas Schwinge
2013-04-26 17:50 ` Samuel Thibault [this message]
2013-04-26 19:02 ` Joel Brobecker
2013-04-26 19:03 ` Alfred M. Szmidt
2013-04-30 12:02 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130426111926.GX5825@type.youpi.perso.aquilenet.fr \
--to=samuel.thibault@gnu.org \
--cc=brobecker@adacore.com \
--cc=bug-hurd@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=thomas@schwinge.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox